Hi,
> -Original Message-
> From: Viacheslav Ovsiienko
> Sent: Thursday, May 14, 2020 10:09 AM
> To: dev@dpdk.org
> Cc: Matan Azrad ; Raslan Darawsheh
> ; step...@networkplumber.org; Alexander
> Kozyrev ; sta...@dpdk.org
> Subject: [PATCH v2] common/mlx5: fix bogus assert
>
> The MLX5 dev
From: Viacheslav Ovsiienko
> The MLX5 device supports up to MLX5_MAX_MAC_ADDRESSES (256) MAC
> addresses.
> The code flushes all MAC devices.
>
> If DPDK is compiled with MLX5_DEBUG this would an assert.
> PANIC in mlx5_nl_mac_addr_flush():
> line 775 assert "(size_t)(i) < sizeof(mac_own)
> -Original Message-
> From: Alexander Kozyrev
> Sent: Thursday, May 14, 2020 18:11
> To: Slava Ovsiienko ; dev@dpdk.org
> Cc: Matan Azrad ; Raslan Darawsheh
> ; step...@networkplumber.org; sta...@dpdk.org
> Subject: RE: [PATCH v2] common/mlx5: fix bogus assert
>
> These asserts seem redu
These asserts seem redundant for me. Don't you think?
EINVAL is returned, why bother to assert the same condition?
Regards,
Alex
> -Original Message-
> From: Viacheslav Ovsiienko
> Sent: Thursday, May 14, 2020 3:09
> To: dev@dpdk.org
> Cc: Matan Azrad ; Raslan Darawsheh
> ; step...@net
The MLX5 device supports up to MLX5_MAX_MAC_ADDRESSES (256) MAC addresses.
The code flushes all MAC devices.
If DPDK is compiled with MLX5_DEBUG this would an assert.
PANIC in mlx5_nl_mac_addr_flush():
line 775assert "(size_t)(i) < sizeof(mac_own) * 8" failed
The root cause is that mac_ow
5 matches
Mail list logo
