31/10/2018 17:28, Thomas Monjalon:
> Including svg files with the svg extension is a common mistake:
> .. figure:: example.svg
> must be
> .. figure:: example.*
> So it will work also when building pdf doc with figures converted
> to png files.
>
> A check is added in checkpatches.sh.
01/11/2018 14:59, Arnon Warshavsky:
> >
> >> Yes it is a good idea.
> >> I think it can be a separate patch. Would you like to send it please?
> >>
> >> Sure. Will do
> >
> > Just to make sure - I am waiting for your patch to get in, so that I apply
> the warning patch for both checks
OK
>
>> Yes it is a good idea.
>> I think it can be a separate patch. Would you like to send it please?
>>
>> Sure. Will do
>
> Just to make sure - I am waiting for your patch to get in, so that I apply
the warning patch for both checks
--
*Arnon Warshavsky*
*Qwilt | work: +972-72-2221634 | mobile
>
>
> Yes it is a good idea.
> I think it can be a separate patch. Would you like to send it please?
>
> Sure. Will do
01/11/2018 07:45, Arnon Warshavsky:
> Hi
>
> >PS: the warning contains the regex. May it be improved?
>
> How about passing an explicit warning message to the awk instead of the
> regex?
Yes it is a good idea.
I think it can be a separate patch. Would you like to send it please?
[..]
> +
Hi
>PS: the warning contains the regex. May it be improved?
How about passing an explicit warning message to the awk instead of the
regex?
+++ b/devtools/check-forbidden-tokens.awk
END {
if (count > 0) {
print "Warning in " substr(last_file,6) ":"
- print "
Including svg files with the svg extension is a common mistake:
.. figure:: example.svg
must be
.. figure:: example.*
So it will work also when building pdf doc with figures converted
to png files.
A check is added in checkpatches.sh.
Signed-off-by: Thomas Monjalon
Signed-off-by:
7 matches
Mail list logo
