Re: [dpdk-dev] [PATCH v2] doc: announce API changes for Windows compatibility

2021-03-16 Thread Thomas Monjalon
11/03/2021 00:54, Dmitry Kozlyuk: > Windows socket headers define `s_addr`, `min`, and `max` macros which > break structure definitions containing fields with one of these names. > Undefining those macros would break some consumers as well. > > Example 1: > > #include > #include > s

Re: [dpdk-dev] [PATCH v2] doc: announce API changes for Windows compatibility

2021-03-11 Thread Tyler Retzlaff
On Thu, Mar 11, 2021 at 08:01:01PM +0300, Dmitry Kozlyuk wrote: > 2021-03-11 16:19 (UTC+), John Alexander: > [...] > > > * `struct rte_param_log2_range`, `struct rte_crypto_param_range`: > > > > > > * `min` -> `minimum` > > > * `max` -> `maximum` > > > > > > The min/max macros in t

Re: [dpdk-dev] [PATCH v2] doc: announce API changes for Windows compatibility

2021-03-11 Thread Dmitry Kozlyuk
2021-03-11 16:19 (UTC+), John Alexander: [...] > > * `struct rte_param_log2_range`, `struct rte_crypto_param_range`: > > > > * `min` -> `minimum` > > * `max` -> `maximum` > > > The min/max macros in the Windows headers cause issues with C++ projects also > (breaks std::min/std::ma

Re: [dpdk-dev] [PATCH v2] doc: announce API changes for Windows compatibility

2021-03-11 Thread John Alexander
; Fiona Trahe ; Ashish > Gupta ; Dmitry Kozlyuk > ; Ray Kinsella ; Neil Horman > > Subject: [dpdk-dev] [PATCH v2] doc: announce API changes for Windows > compatibility > > CAUTION: This email originated from outside of the organization. Do not click > links or open attachments unl

[dpdk-dev] [PATCH v2] doc: announce API changes for Windows compatibility

2021-03-10 Thread Dmitry Kozlyuk
Windows socket headers define `s_addr`, `min`, and `max` macros which break structure definitions containing fields with one of these names. Undefining those macros would break some consumers as well. Example 1: #include #include struct in_addr addr; /* addr.s_addr = 0; ERRO