Re: [dpdk-dev] [PATCH v2] eal/service: fix exit by resetting service lcores

2020-04-14 Thread Aaron Conole
"Burakov, Anatoly" writes: > On 13-Mar-20 10:04 AM, David Marchand wrote: >> On Wed, Mar 11, 2020 at 3:39 PM Harry van Haaren >> wrote: >>> >>> This commit releases all service cores from their role, >>> returning them to ROLE_RTE on rte_service_finalize(). >>> >>> This may fix an issue relating

Re: [dpdk-dev] [PATCH v2] eal/service: fix exit by resetting service lcores

2020-04-06 Thread Burakov, Anatoly
On 13-Mar-20 10:04 AM, David Marchand wrote: On Wed, Mar 11, 2020 at 3:39 PM Harry van Haaren wrote: This commit releases all service cores from their role, returning them to ROLE_RTE on rte_service_finalize(). This may fix an issue relating to the service cores causing s/may fix/fixes/ a

Re: [dpdk-dev] [PATCH v2] eal/service: fix exit by resetting service lcores

2020-03-13 Thread David Marchand
On Wed, Mar 11, 2020 at 3:39 PM Harry van Haaren wrote: > > This commit releases all service cores from their role, > returning them to ROLE_RTE on rte_service_finalize(). > > This may fix an issue relating to the service cores causing s/may fix/fixes/ > a race-condition on eal_cleanup(), where

Re: [dpdk-dev] [PATCH v2] eal/service: fix exit by resetting service lcores

2020-03-12 Thread David Marchand
On Wed, Mar 11, 2020 at 6:08 PM Aaron Conole wrote: > > David Marchand writes: > > > On Wed, Mar 11, 2020 at 3:39 PM Harry van Haaren > > wrote: > >> > >> This commit releases all service cores from their role, > >> returning them to ROLE_RTE on rte_service_finalize(). > >> > >> This may fix an

Re: [dpdk-dev] [PATCH v2] eal/service: fix exit by resetting service lcores

2020-03-12 Thread David Marchand
Hello, On Wed, Mar 11, 2020 at 5:21 PM Van Haaren, Harry wrote: > Issue was that service cores can remain running while main thread > has freed service-core memory, later racy return of service lcore > then causes use-after-free. > > This commit fixes it by > A) resetting all service cores to ret

Re: [dpdk-dev] [PATCH v2] eal/service: fix exit by resetting service lcores

2020-03-11 Thread Aaron Conole
David Marchand writes: > On Wed, Mar 11, 2020 at 3:39 PM Harry van Haaren > wrote: >> >> This commit releases all service cores from their role, >> returning them to ROLE_RTE on rte_service_finalize(). >> >> This may fix an issue relating to the service cores causing > > You don't seem convinced

Re: [dpdk-dev] [PATCH v2] eal/service: fix exit by resetting service lcores

2020-03-11 Thread Van Haaren, Harry
> -Original Message- > From: David Marchand > Sent: Wednesday, March 11, 2020 4:16 PM > To: Van Haaren, Harry > Cc: dev ; Aaron Conole ; dpdk stable > > Subject: Re: [PATCH v2] eal/service: fix exit by resetting service lcores > > On Wed, Mar 11, 2020 at 3:39 PM Harry van Haaren > wrot

Re: [dpdk-dev] [PATCH v2] eal/service: fix exit by resetting service lcores

2020-03-11 Thread David Marchand
On Wed, Mar 11, 2020 at 3:39 PM Harry van Haaren wrote: > > This commit releases all service cores from their role, > returning them to ROLE_RTE on rte_service_finalize(). > > This may fix an issue relating to the service cores causing You don't seem convinced. > a race-condition on eal_cleanup

[dpdk-dev] [PATCH v2] eal/service: fix exit by resetting service lcores

2020-03-11 Thread Harry van Haaren
This commit releases all service cores from their role, returning them to ROLE_RTE on rte_service_finalize(). This may fix an issue relating to the service cores causing a race-condition on eal_cleanup(), where the service core could still be executing while the main thread has already free-d the