Thanks, that was quick! Quicker than me, actually. ;-)
I started to rebase and modify my previous patch as well but I got a bit
stuck because I wanted to try to solve the command order issue that
Aaron mentioned. In fact, I agree with him in this point. However, I
figured out that more precedi
2014-11-05 11:54, Ananyev, Konstantin:
> From: Thomas Monjalon
> > + long master_lcore;
> > + char *parsing_end;
> > + struct rte_config *cfg = rte_eal_get_configuration();
> > +
> > + errno = 0;
> > + master_lcore = strtol(arg, &parsing_end, 0);
> > + if (errno || parsing_end == arg)
>
Hi Thomas,
Few questions/comments below.
Konstantin
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Thomas Monjalon
> Sent: Tuesday, November 04, 2014 9:41 PM
> To: dev at dpdk.org
> Subject: [dpdk-dev] [PATCH v2] eal: add option --master-lcore
>
> From: Simon Ku
Acked-by: Aaron Campbell mailto:aaron at arbor.net>>
Minor comments inline below, I don?t need to see another patch.
Thanks,
-Aaron
> On Nov 4, 2014, at 5:40 PM, Thomas Monjalon
> wrote:
>
> + RTE_LOG(ERR, EAL, "please specify the master lcore id"
> +
From: Simon Kuenzer
Enable users to specify the lcore id that is used as master lcore.
Signed-off-by: Simon Kuenzer
Signed-off-by: Thomas Monjalon
---
changes in v2:
- rebase on HEAD including common options for BSD and Linux
- use strtol() instead of atoi() to check syntax errors
- unit test
5 matches
Mail list logo
