Re: [dpdk-dev] [PATCH v2] ethdev: fix multi-process NULL dereference crashes

2017-01-25 Thread Remy Horton
On 25/01/2017 14:31, Thomas Monjalon wrote: 2017-01-25 14:02, Remy Horton: [..] Self-NAK: Condition is now tautology on code path that was causing crashes What do you mean exactly? There is an if(rte_eal_process_type() == RTE_PROC_PRIMARY) in a calling function, so the one my patch was in

Re: [dpdk-dev] [PATCH v2] ethdev: fix multi-process NULL dereference crashes

2017-01-25 Thread Thomas Monjalon
2017-01-25 14:02, Remy Horton: > > On 24/01/2017 15:01, Remy Horton wrote: > > Secondary processes were blanket zeroing ethernet device memory, > > resulting in NULL dereference crashes in multi-process setups. > > > > Fixes: 7f95f78a8aea ("ethdev: clear data when allocating device") > > > > Signe

Re: [dpdk-dev] [PATCH v2] ethdev: fix multi-process NULL dereference crashes

2017-01-25 Thread Remy Horton
On 24/01/2017 15:01, Remy Horton wrote: Secondary processes were blanket zeroing ethernet device memory, resulting in NULL dereference crashes in multi-process setups. Fixes: 7f95f78a8aea ("ethdev: clear data when allocating device") Signed-off-by: Remy Horton Self-NAK: Condition is now tau

Re: [dpdk-dev] [PATCH v2] ethdev: fix multi-process NULL dereference crashes

2017-01-25 Thread Remy Horton
On 25/01/2017 11:56, Thomas Monjalon wrote: [..] It does not describe exactly the use-case it is fixing (same in commit message). I guess you saw an issue when creating a vdev in the primary process and another one in a secondary process, erasing the data of the first one. In my use-case the s

Re: [dpdk-dev] [PATCH v2] ethdev: fix multi-process NULL dereference crashes

2017-01-25 Thread Thomas Monjalon
2017-01-24 15:01, Remy Horton: > Secondary processes were blanket zeroing ethernet device memory, > resulting in NULL dereference crashes in multi-process setups. > > Fixes: 7f95f78a8aea ("ethdev: clear data when allocating device") > > Signed-off-by: Remy Horton > --- > doc/guides/rel_notes/re

[dpdk-dev] [PATCH v2] ethdev: fix multi-process NULL dereference crashes

2017-01-24 Thread Remy Horton
Secondary processes were blanket zeroing ethernet device memory, resulting in NULL dereference crashes in multi-process setups. Fixes: 7f95f78a8aea ("ethdev: clear data when allocating device") Signed-off-by: Remy Horton --- doc/guides/rel_notes/release_17_02.rst | 5 + lib/librte_ether/rte