Re: [dpdk-dev] [PATCH v2] ethdev: fix updating device data when ops pointer is NULL

2020-01-17 Thread Wei Hu (Xavier)
Hi,Andrew Rybchenko On 2020/1/17 15:57, Andrew Rybchenko wrote: On 1/17/20 9:23 AM, Wei Hu (Xavier) wrote: From: "Wei Hu (Xavier)" I think summary is misleading. It is too generic and does not mention VLAN offloads. Consider something like: ethdev: fix VLAN offloads set if no driver callback

Re: [dpdk-dev] [PATCH v2] ethdev: fix updating device data when ops pointer is NULL

2020-01-16 Thread Andrew Rybchenko
On 1/17/20 9:23 AM, Wei Hu (Xavier) wrote: > From: "Wei Hu (Xavier)" I think summary is misleading. It is too generic and does not mention VLAN offloads. Consider something like: ethdev: fix VLAN offloads set if no driver callback > Currently, there is a potential problem that changing the conte

[dpdk-dev] [PATCH v2] ethdev: fix updating device data when ops pointer is NULL

2020-01-16 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" Currently, there is a potential problem that changing the content of dev->data->dev_conf.rxmode.offloads even when the pointer named dev->dev_ops->vlan_offload_set is NULL in the API function named rte_eth_dev_set_vlan_offload. It is a good idea that prevent the side effe