Re: [dpdk-dev] [PATCH v2] ethdev: return diagnostic when setting MAC address

2018-04-04 Thread Shreyansh Jain
van Malov ; Ivan > Malov > Subject: [dpdk-dev] [PATCH v2] ethdev: return diagnostic when setting > MAC address > > Change the prototype and the behavior of dev_ops->eth_mac_addr_set(): a > return code is added to notify the caller (librte_ether) if an error > occurred in

Re: [dpdk-dev] [PATCH v2] ethdev: return diagnostic when setting MAC address

2018-04-03 Thread Olivier Matz
On Tue, Apr 03, 2018 at 04:57:24PM +0200, Adrien Mazarguil wrote: > On Tue, Apr 03, 2018 at 02:41:03PM +0200, Olivier Matz wrote: > > Change the prototype and the behavior of dev_ops->eth_mac_addr_set(): a > > return code is added to notify the caller (librte_ether) if an error > > occurred in the

Re: [dpdk-dev] [PATCH v2] ethdev: return diagnostic when setting MAC address

2018-04-03 Thread Olivier Matz
On Tue, Apr 03, 2018 at 05:19:06PM +0100, Ferruh Yigit wrote: > On 4/3/2018 1:41 PM, Olivier Matz wrote: > > diff --git a/drivers/net/mvpp2/mrvl_ethdev.c > > b/drivers/net/mvpp2/mrvl_ethdev.c > > index 6ab515ca9..87748f789 100644 > > --- a/drivers/net/mvpp2/mrvl_ethdev.c > > +++ b/drivers/net/mvpp

Re: [dpdk-dev] [PATCH v2] ethdev: return diagnostic when setting MAC address

2018-04-03 Thread Ferruh Yigit
On 4/3/2018 1:41 PM, Olivier Matz wrote: > diff --git a/drivers/net/mvpp2/mrvl_ethdev.c b/drivers/net/mvpp2/mrvl_ethdev.c > index 6ab515ca9..87748f789 100644 > --- a/drivers/net/mvpp2/mrvl_ethdev.c > +++ b/drivers/net/mvpp2/mrvl_ethdev.c > @@ -987,7 +987,7 @@ mrvl_mac_addr_remove(struct rte_eth_dev

Re: [dpdk-dev] [PATCH v2] ethdev: return diagnostic when setting MAC address

2018-04-03 Thread Adrien Mazarguil
On Tue, Apr 03, 2018 at 02:41:03PM +0200, Olivier Matz wrote: > Change the prototype and the behavior of dev_ops->eth_mac_addr_set(): a > return code is added to notify the caller (librte_ether) if an error > occurred in the PMD. > > The new default MAC address is now copied in dev->data->mac_addr

Re: [dpdk-dev] [PATCH v2] ethdev: return diagnostic when setting MAC address

2018-04-03 Thread Andrew Rybchenko
On 04/03/2018 03:41 PM, Olivier Matz wrote: Change the prototype and the behavior of dev_ops->eth_mac_addr_set(): a return code is added to notify the caller (librte_ether) if an error occurred in the PMD. The new default MAC address is now copied in dev->data->mac_addrs[0] only if the operation

[dpdk-dev] [PATCH v2] ethdev: return diagnostic when setting MAC address

2018-04-03 Thread Olivier Matz
Change the prototype and the behavior of dev_ops->eth_mac_addr_set(): a return code is added to notify the caller (librte_ether) if an error occurred in the PMD. The new default MAC address is now copied in dev->data->mac_addrs[0] only if the operation is successful. The patch also updates all th