Re: [dpdk-dev] [PATCH v2] examples/ip_pipeline: fix buffer not null terminated.

2018-05-08 Thread Dumitrescu, Cristian
> -Original Message- > From: Zhang, Roy Fan > Sent: Tuesday, April 17, 2018 10:46 AM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian ; Singh, Jasvinder > > Subject: [PATCH v2] examples/ip_pipeline: fix buffer not null terminated. > > Coverity issue: 272563 > Fixes: 8245472c58c8 ("examples

Re: [dpdk-dev] [PATCH v2] examples/ip_pipeline: fix buffer not null terminated

2018-05-08 Thread Dumitrescu, Cristian
> -Original Message- > From: Singh, Jasvinder > Sent: Tuesday, April 17, 2018 5:40 PM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian ; Richardson, Bruce > > Subject: [PATCH v2] examples/ip_pipeline: fix buffer not null terminated > > The destination string may not have a null termination

[dpdk-dev] [PATCH v2] examples/ip_pipeline: fix buffer not null terminated

2018-04-17 Thread Jasvinder Singh
The destination string may not have a null termination if the source string's length is equal to the sizeof(pipeline->name). Fix by replacing strncpy with strlcpy that guarantees NULL-termination. Coverty issue: 272606 Fixes: d75c371e9b46 ("examples/ip_pipeline: add pipeline object") Signed-off-

Re: [dpdk-dev] [PATCH v2] examples/ip_pipeline: fix buffer not null terminated.

2018-04-17 Thread Bruce Richardson
On Tue, Apr 17, 2018 at 10:45:46AM +0100, Fan Zhang wrote: > Coverity issue: 272563 > Fixes: 8245472c58c8 ("examples/ip_pipeline: add sw queue object") > > Signed-off-by: Fan Zhang > --- Acked-by: Bruce Richardson

Re: [dpdk-dev] [PATCH v2] examples/ip_pipeline: fix buffer not null terminated

2018-04-17 Thread Bruce Richardson
On Tue, Apr 17, 2018 at 10:52:52AM +0100, Fan Zhang wrote: > Coverity issue: 272572 > Fixes: 719374345cee ("examples/ip_pipeline: add action profile objects") > > Signed-off-by: Fan Zhang > --- > v2: > - use more generic strlcpy approach > > examples/ip_pipeline/action.c | 4 +++- > 1 file chan

[dpdk-dev] [PATCH v2] examples/ip_pipeline: fix buffer not null terminated

2018-04-17 Thread Fan Zhang
Coverity issue: 272572 Fixes: 719374345cee ("examples/ip_pipeline: add action profile objects") Signed-off-by: Fan Zhang --- v2: - use more generic strlcpy approach examples/ip_pipeline/action.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/examples/ip_pipeline/action.c

[dpdk-dev] [PATCH v2] examples/ip_pipeline: fix buffer not null terminated.

2018-04-17 Thread Fan Zhang
Coverity issue: 272563 Fixes: 8245472c58c8 ("examples/ip_pipeline: add sw queue object") Signed-off-by: Fan Zhang --- v2: - using more generic strlcpy approach examples/ip_pipeline/swq.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/examples/ip_pipeline/swq.c b/example