Re: [dpdk-dev] [PATCH v2] gso: fix free issue of mbuf gso segments attach to

2020-10-25 Thread Jiayu Hu
On Mon, Oct 26, 2020 at 10:12:24AM +0800, yang_y_yi wrote: > At 2020-10-26 10:06:09, "Jiayu Hu" wrote: > > >On Mon, Oct 26, 2020 at 08:57:30AM +0800, yang_y_yi wrote: > >> At 2020-10-23 22:46:42, "Ananyev, Konstantin" > >> > >> wrote: > >> > >> >> From: yang_y_yi > >> >> Sent: Friday, October

Re: [dpdk-dev] [PATCH v2] gso: fix free issue of mbuf gso segments attach to

2020-10-25 Thread yang_y_yi
At 2020-10-26 10:06:09, "Jiayu Hu" wrote: >On Mon, Oct 26, 2020 at 08:57:30AM +0800, yang_y_yi wrote: >> At 2020-10-23 22:46:42, "Ananyev, Konstantin" >> wrote: >> >> >> From: yang_y_yi >> >> Sent: Friday, October 23, 2020 2:18 PM >> >> To: Ananyev, Konstantin >> >> Cc: dev@dpdk.org; Hu, Jiayu

Re: [dpdk-dev] [PATCH v2] gso: fix free issue of mbuf gso segments attach to

2020-10-25 Thread Jiayu Hu
On Mon, Oct 26, 2020 at 08:57:30AM +0800, yang_y_yi wrote: > At 2020-10-23 22:46:42, "Ananyev, Konstantin" > wrote: > > >> From: yang_y_yi > >> Sent: Friday, October 23, 2020 2:18 PM > >> To: Ananyev, Konstantin > >> Cc: dev@dpdk.org; Hu, Jiayu ; techbo...@dpdk.org; > >> tho...@monjalon.net; y

Re: [dpdk-dev] [PATCH v2] gso: fix free issue of mbuf gso segments attach to

2020-10-25 Thread yang_y_yi
At 2020-10-23 22:46:42, "Ananyev, Konstantin" wrote: >> From: yang_y_yi >> Sent: Friday, October 23, 2020 2:18 PM >> To: Ananyev, Konstantin >> Cc: dev@dpdk.org; Hu, Jiayu ; techbo...@dpdk.org; >> tho...@monjalon.net; yangy...@inspur.com >> Subject: Re:RE: [PATCH v2] gso: fix free issue of mbu

Re: [dpdk-dev] [PATCH v2] gso: fix free issue of mbuf gso segments attach to

2020-10-23 Thread Ananyev, Konstantin
> From: yang_y_yi > Sent: Friday, October 23, 2020 2:18 PM > To: Ananyev, Konstantin > Cc: dev@dpdk.org; Hu, Jiayu ; techbo...@dpdk.org; > tho...@monjalon.net; yangy...@inspur.com > Subject: Re:RE: [PATCH v2] gso: fix free issue of mbuf gso segments attach to > > Konstantin, thank you so much f

Re: [dpdk-dev] [PATCH v2] gso: fix free issue of mbuf gso segments attach to

2020-10-23 Thread yang_y_yi
At 2020-10-23 08:57:15, "Hu, Jiayu" wrote: > > >> -Original Message- >> From: Ananyev, Konstantin >> Sent: Thursday, October 22, 2020 11:34 PM >> To: yang_y...@163.com; dev@dpdk.org >> Cc: Hu, Jiayu ; techbo...@dpdk.org; >> tho...@monjalon.net; yangy...@inspur.com >> Subject: RE: [PATCH v

Re: [dpdk-dev] [PATCH v2] gso: fix free issue of mbuf gso segments attach to

2020-10-23 Thread yang_y_yi
At 2020-10-22 23:33:42, "Ananyev, Konstantin" wrote: > >> > >> > rte_gso_segment decreased refcnt of pkt by one, but >> > it is wrong if pkt is external mbuf, pkt won't be >> > freed because of incorrect refcnt, the result is >> > application can't allocate mbuf from mempool because >> > mbufs in

Re: [dpdk-dev] [PATCH v2] gso: fix free issue of mbuf gso segments attach to

2020-10-23 Thread yang_y_yi
Konstantin, thank you so much for comments, my replies inline, please check them. At 2020-10-22 21:16:43, "Ananyev, Konstantin" wrote: > >> >> rte_gso_segment decreased refcnt of pkt by one, but >> it is wrong if pkt is external mbuf, pkt won't be >> freed because of incorrect refcnt, the resul

Re: [dpdk-dev] [PATCH v2] gso: fix free issue of mbuf gso segments attach to

2020-10-22 Thread Hu, Jiayu
> -Original Message- > From: Ananyev, Konstantin > Sent: Thursday, October 22, 2020 11:34 PM > To: yang_y...@163.com; dev@dpdk.org > Cc: Hu, Jiayu ; techbo...@dpdk.org; > tho...@monjalon.net; yangy...@inspur.com > Subject: RE: [PATCH v2] gso: fix free issue of mbuf gso segments attach t

Re: [dpdk-dev] [PATCH v2] gso: fix free issue of mbuf gso segments attach to

2020-10-22 Thread Ananyev, Konstantin
> > > > rte_gso_segment decreased refcnt of pkt by one, but > > it is wrong if pkt is external mbuf, pkt won't be > > freed because of incorrect refcnt, the result is > > application can't allocate mbuf from mempool because > > mbufs in mempool are run out of. > > > > One correct way is applicati

Re: [dpdk-dev] [PATCH v2] gso: fix free issue of mbuf gso segments attach to

2020-10-22 Thread Ananyev, Konstantin
> > rte_gso_segment decreased refcnt of pkt by one, but > it is wrong if pkt is external mbuf, pkt won't be > freed because of incorrect refcnt, the result is > application can't allocate mbuf from mempool because > mbufs in mempool are run out of. > > One correct way is application should call

[dpdk-dev] [PATCH v2] gso: fix free issue of mbuf gso segments attach to

2020-10-21 Thread yang_y_yi
From: Yi Yang rte_gso_segment decreased refcnt of pkt by one, but it is wrong if pkt is external mbuf, pkt won't be freed because of incorrect refcnt, the result is application can't allocate mbuf from mempool because mbufs in mempool are run out of. One correct way is application should call rt