Re: [dpdk-dev] [PATCH v2] igb_uio: issue FLR during open and release of device file

2017-07-20 Thread Thomas Monjalon
> > >> Set UIO info device file operations open and release. Call pci reset > > >> function inside open and release to clear device state at start and end. > > >> Copied this behaviour from vfio_pci kernel module code. With this patch, > > >> it is not mandatory to issue FLR by PMD's during init an

Re: [dpdk-dev] [PATCH v2] igb_uio: issue FLR during open and release of device file

2017-07-19 Thread Gregory Etelson
On Wednesday, 19 July 2017 16:32:34 IDT Ferruh Yigit wrote: > On 7/12/2017 4:40 AM, Tan, Jianfeng wrote: > > > > > >> -Original Message- > >> From: Shijith Thotton [mailto:shijith.thot...@caviumnetworks.com] > >> Sent: Friday, July 7, 2017 7:14 PM > >> To: dev@dpdk.org > >> Cc: Yigit, Fe

Re: [dpdk-dev] [PATCH v2] igb_uio: issue FLR during open and release of device file

2017-07-19 Thread Ferruh Yigit
On 7/12/2017 4:40 AM, Tan, Jianfeng wrote: > > >> -Original Message- >> From: Shijith Thotton [mailto:shijith.thot...@caviumnetworks.com] >> Sent: Friday, July 7, 2017 7:14 PM >> To: dev@dpdk.org >> Cc: Yigit, Ferruh; Gregory Etelson; Thomas Monjalon; Stephen Hemminger; >> Tan, Jianfeng;

Re: [dpdk-dev] [PATCH v2] igb_uio: issue FLR during open and release of device file

2017-07-15 Thread Gregory Etelson
Hello Shijith, Please add the patch to uio_pci_generic.c file in Linux kernel We experience similar faults with NVMe devices On Wednesday, 12 July 2017 06:40:55 IDT Tan, Jianfeng wrote: > > > -Original Message- > > From: Shijith Thotton [mailto:shijith.thot...@caviumnetworks.com] > > S

Re: [dpdk-dev] [PATCH v2] igb_uio: issue FLR during open and release of device file

2017-07-11 Thread Tan, Jianfeng
> -Original Message- > From: Shijith Thotton [mailto:shijith.thot...@caviumnetworks.com] > Sent: Friday, July 7, 2017 7:14 PM > To: dev@dpdk.org > Cc: Yigit, Ferruh; Gregory Etelson; Thomas Monjalon; Stephen Hemminger; > Tan, Jianfeng; Lu, Wenzhuo > Subject: [PATCH v2] igb_uio: issue FLR

Re: [dpdk-dev] [PATCH v2] igb_uio: issue FLR during open and release of device file

2017-07-11 Thread Tan, Jianfeng
> -Original Message- > From: Shijith Thotton [mailto:shijith.thot...@caviumnetworks.com] > Sent: Monday, July 10, 2017 6:43 PM > To: Tan, Jianfeng > Cc: dev@dpdk.org; Yigit, Ferruh; Gregory Etelson; Thomas Monjalon; > Stephen Hemminger; Lu, Wenzhuo > Subject: Re: [PATCH v2] igb_uio: issue

Re: [dpdk-dev] [PATCH v2] igb_uio: issue FLR during open and release of device file

2017-07-11 Thread Gregory Etelson
Hello Ferruh, All tests have passed successfully. Regards, Gregory Hello Ferruh, Both patches [1] http://dpdk.org/dev/patchwork/patch/26633/ and [2] http://dpdk.org/dev/patchwork/patch/25061/ have failed the same test. This is kind of strange because [2] has already passed that test numerous

Re: [dpdk-dev] [PATCH v2] igb_uio: issue FLR during open and release of device file

2017-07-10 Thread Gregory Etelson
Hello Ferruh, Both patches [1] http://dpdk.org/dev/patchwork/patch/26633/ and [2] http://dpdk.org/dev/patchwork/patch/25061/ have failed the same test. This is kind of strange because [2] has already passed that test numerous times. I'll recalibrate my cluster and run the test again. Besides that

Re: [dpdk-dev] [PATCH v2] igb_uio: issue FLR during open and release of device file

2017-07-10 Thread Shijith Thotton
On Mon, Jul 10, 2017 at 09:00:38AM +, Tan, Jianfeng wrote: > > > > -Original Message- > > From: Shijith Thotton [mailto:shijith.thot...@caviumnetworks.com] > > Sent: Monday, July 10, 2017 3:11 PM > > To: Tan, Jianfeng > > Cc: dev@dpdk.org; Yigit, Ferruh; Gregory Etelson; Thomas Monjal

Re: [dpdk-dev] [PATCH v2] igb_uio: issue FLR during open and release of device file

2017-07-10 Thread Tan, Jianfeng
> -Original Message- > From: Shijith Thotton [mailto:shijith.thot...@caviumnetworks.com] > Sent: Monday, July 10, 2017 3:11 PM > To: Tan, Jianfeng > Cc: dev@dpdk.org; Yigit, Ferruh; Gregory Etelson; Thomas Monjalon; > Stephen Hemminger; Lu, Wenzhuo > Subject: Re: [PATCH v2] igb_uio: issue

Re: [dpdk-dev] [PATCH v2] igb_uio: issue FLR during open and release of device file

2017-07-10 Thread Shijith Thotton
On Mon, Jul 10, 2017 at 03:38:34AM +, Tan, Jianfeng wrote: > Hi Thotton, > > > -Original Message- > > From: Shijith Thotton [mailto:shijith.thot...@caviumnetworks.com] > > Sent: Friday, July 7, 2017 7:14 PM > > To: dev@dpdk.org > > Cc: Yigit, Ferruh; Gregory Etelson; Thomas Monjalon; S

Re: [dpdk-dev] [PATCH v2] igb_uio: issue FLR during open and release of device file

2017-07-09 Thread Tan, Jianfeng
Hi Thotton, > -Original Message- > From: Shijith Thotton [mailto:shijith.thot...@caviumnetworks.com] > Sent: Friday, July 7, 2017 7:14 PM > To: dev@dpdk.org > Cc: Yigit, Ferruh; Gregory Etelson; Thomas Monjalon; Stephen Hemminger; > Tan, Jianfeng; Lu, Wenzhuo > Subject: [PATCH v2] igb_uio:

Re: [dpdk-dev] [PATCH v2] igb_uio: issue FLR during open and release of device file

2017-07-09 Thread Gregory Etelson
Hello Ferruh, I could not reproduce server crash with the patch. However, some tests report ixgbe_vf_pmd and i40e_vf_pmd do not receive and transmit frames after process restart, although PMD initialization completed successfully Is there a way to collect PF firmware dump for investigation ? Reg

Re: [dpdk-dev] [PATCH v2] igb_uio: issue FLR during open and release of device file

2017-07-07 Thread Ferruh Yigit
On 7/7/2017 12:13 PM, Shijith Thotton wrote: > Set UIO info device file operations open and release. Call pci reset > function inside open and release to clear device state at start and end. > Copied this behaviour from vfio_pci kernel module code. With this patch, > it is not mandatory to issue FL

[dpdk-dev] [PATCH v2] igb_uio: issue FLR during open and release of device file

2017-07-07 Thread Shijith Thotton
Set UIO info device file operations open and release. Call pci reset function inside open and release to clear device state at start and end. Copied this behaviour from vfio_pci kernel module code. With this patch, it is not mandatory to issue FLR by PMD's during init and close. Bus master enable