Hi Ferruh,
Thank you for all your comments.
The only real purpose of the patch is to support .get_link for all KNI
interfaces, not just for those using igb or ixgbe.
So I propose to remove ethtool support at all with your patch, and after
that, I will add .get_link support again.
Yes, I understa
On 12/3/2018 2:06 PM, Igor Ryzhov wrote:
> Hi Ferruh,
>
> What about the patch?
>
> I also support dropping ethtool for ixgbe and i40e, but to save generic
> ethtool_ops
> with .get_link implementation, because it's an essential function that works
> correctly
> after proper implementation of ca
On 12/1/2018 11:12 AM, Igor Ryzhov wrote:
> Hi Stephen,
>
> I also do not see the point of the current implementation of ethtool
> support.
> That's why I sent this patch – it enables ethtool_ops for all devices,
> independent of the underlying driver.
I tried to clarify this in the patch, but it
On 11/30/2018 7:47 PM, Igor Ryzhov wrote:
> Current implementation of kni_ethtool_ops just uses corresponding
> ethtool_ops function of underlying driver for all functions except for
> .get_link. This commit sets kni->net_dev->ethtool_ops directly to the
> ethtool_ops of the corresponding driver.
I
On Sun, 2 Dec 2018 13:54:11 +0300
Igor Ryzhov wrote:
> Stephen,
>
> ethtool_get_link returns EOPNOTSUPP if device doesn't supply get_link:
>
You are right, kni needs to supply ethool ops and can use the standard
ethtool_op_get_link as the callback.
Hi Ferruh,
What about the patch?
I also support dropping ethtool for ixgbe and i40e, but to save generic
ethtool_ops
with .get_link implementation, because it's an essential function that
works correctly
after proper implementation of carrier status that was merged into 18.11.
Also, other ethtoo
On 11/30/2018 11:38 PM, Stephen Hemminger wrote:
> On Fri, 30 Nov 2018 22:47:50 +0300
> Igor Ryzhov wrote:
>
>> Current implementation of kni_ethtool_ops just uses corresponding
>> ethtool_ops function of underlying driver for all functions except for
>> .get_link. This commit sets kni->net_dev->
Stephen,
ethtool_get_link returns EOPNOTSUPP if device doesn't supply get_link:
static int ethtool_get_link(struct net_device *dev, char __user *useraddr)
{
struct ethtool_value edata = { .cmd = ETHTOOL_GLINK };
if (!dev->ethtool_ops->get_link)
return -EOPNOTSUPP;
edata.data = netif_running(dev
On Sat, 1 Dec 2018 14:12:54 +0300
Igor Ryzhov wrote:
> Hi Stephen,
>
> I also do not see the point of the current implementation of ethtool
> support.
> That's why I sent this patch – it enables ethtool_ops for all devices,
> independent of the underlying driver.
> Right now only .get_link is su
Hi Stephen,
I also do not see the point of the current implementation of ethtool
support.
That's why I sent this patch – it enables ethtool_ops for all devices,
independent of the underlying driver.
Right now only .get_link is supported, but I am thinking about
implementation of a larger set of fu
On Fri, 30 Nov 2018 22:47:50 +0300
Igor Ryzhov wrote:
> Current implementation of kni_ethtool_ops just uses corresponding
> ethtool_ops function of underlying driver for all functions except for
> .get_link. This commit sets kni->net_dev->ethtool_ops directly to the
> ethtool_ops of the correspon
Current implementation of kni_ethtool_ops just uses corresponding
ethtool_ops function of underlying driver for all functions except for
.get_link. This commit sets kni->net_dev->ethtool_ops directly to the
ethtool_ops of the corresponding driver.
For unknown drivers (all but ixgbe and i40e) we st
12 matches
Mail list logo
