[dpdk-dev] [PATCH v2] log: respect rte_openlog_stream calls before rte_eal_init

2016-10-12 Thread Thomas Monjalon
2016-10-11 14:46, John Ousterhout: > All of your suggestions look reasonable and fairly straightforward; I'll > work on a new patch that includes them. > > Given that rte_eal_log_init is a no-op (and won't even be invoked), would > it be better to remove that function completely, and even delete t

[dpdk-dev] [PATCH v2] log: respect rte_openlog_stream calls before rte_eal_init

2016-10-11 Thread Thomas Monjalon
2016-10-11 09:30, John Ousterhout: > On Tue, Oct 11, 2016 at 1:08 AM, Thomas Monjalon 6wind.com> > wrote: > > > > 2016-10-10 15:39, John Ousterhout: > > > ... > > > > > > Note: I see from the code that Linux and BSD set different default > streams: > > > Linux uses stdout, while BSD uses stderr. T

[dpdk-dev] [PATCH v2] log: respect rte_openlog_stream calls before rte_eal_init

2016-10-11 Thread Don Provan
> -Original Message- > From: John Ousterhout [mailto:ouster at cs.stanford.edu] > Sent: Tuesday, October 11, 2016 9:30 AM > To: Thomas Monjalon > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] log: respect rte_openlog_stream calls > before rte_eal_init >

[dpdk-dev] [PATCH v2] log: respect rte_openlog_stream calls before rte_eal_init

2016-10-11 Thread John Ousterhout
9:30 AM > > To: Thomas Monjalon > > Cc: dev at dpdk.org > > Subject: Re: [dpdk-dev] [PATCH v2] log: respect rte_openlog_stream calls > > before rte_eal_init > > > > On Tue, Oct 11, 2016 at 1:08 AM, Thomas Monjalon > > > > wrote: > > > I don

[dpdk-dev] [PATCH v2] log: respect rte_openlog_stream calls before rte_eal_init

2016-10-11 Thread John Ousterhout
All of your suggestions look reasonable and fairly straightforward; I'll work on a new patch that includes them. Given that rte_eal_log_init is a no-op (and won't even be invoked), would it be better to remove that function completely, and even delete the file containing it (eal_log.c), or is it b

[dpdk-dev] [PATCH v2] log: respect rte_openlog_stream calls before rte_eal_init

2016-10-11 Thread Thomas Monjalon
2016-10-10 15:39, John Ousterhout: > Before this patch, application-specific loggers could not be > installed before rte_eal_init completed (the initialization process > called rte_openlog_stream, overwriting any previously installed > logger). This made it impossible for an application to capture

[dpdk-dev] [PATCH v2] log: respect rte_openlog_stream calls before rte_eal_init

2016-10-11 Thread John Ousterhout
On Tue, Oct 11, 2016 at 1:08 AM, Thomas Monjalon wrote: > > 2016-10-10 15:39, John Ousterhout: > > ... > > > > Note: I see from the code that Linux and BSD set different default streams: > > Linux uses stdout, while BSD uses stderr. This patch retains the distinction, > > though I'm not sure why i

[dpdk-dev] [PATCH v2] log: respect rte_openlog_stream calls before rte_eal_init

2016-10-10 Thread John Ousterhout
Before this patch, application-specific loggers could not be installed before rte_eal_init completed (the initialization process called rte_openlog_stream, overwriting any previously installed logger). This made it impossible for an application to capture the initial log messages generated during r