Re: [dpdk-dev] [PATCH v2] net/i40e: fix TSO pkt exceeds allowed buf size issue

2019-12-25 Thread Li, Xiaoyun
Sure. Will fix them in v3. Thanks. > -Original Message- > From: Zhang, Qi Z > Sent: Thursday, December 26, 2019 09:51 > To: Li, Xiaoyun ; Xing, Beilei ; > Ye, > Xiaolong ; Loftus, Ciara ; > dev@dpdk.org > Cc: sta...@dpdk.org > Subject: RE: [PATCH v2] net/i40e: fix TSO pkt exceeds allowed

Re: [dpdk-dev] [PATCH v2] net/i40e: fix TSO pkt exceeds allowed buf size issue

2019-12-25 Thread Zhang, Qi Z
HI Xiaoyun: Overall looks good to me, some minor capture inline > -Original Message- > From: Li, Xiaoyun > Sent: Wednesday, December 25, 2019 4:56 PM > To: Zhang, Qi Z ; Xing, Beilei ; > Ye, Xiaolong ; Loftus, Ciara ; > dev@dpdk.org > Cc: Li, Xiaoyun ; sta...@dpdk.org > Subject:

[dpdk-dev] [PATCH v2] net/i40e: fix TSO pkt exceeds allowed buf size issue

2019-12-25 Thread Xiaoyun Li
Hardware limits that max buffer size per tx descriptor should be (16K-1)B. So when TSO enabled, the mbuf data size may exceed the limit and cause malicious behaviour to the NIC. This patch fixes this issue by using more tx descs for this kind of large buffer. Fixes: 4861cde46116 ("i40e: new poll m