Re: [dpdk-dev] [PATCH v2] net/ice: remove unnecessary variable

2020-03-03 Thread Zhang, Qi Z
> -Original Message- > From: Ye, Xiaolong > Sent: Tuesday, March 3, 2020 4:27 PM > To: Zhang, Qi Z > Cc: Cao, Yahui ; Su, Simei ; Zhao, > Wei ; dev@dpdk.org; sta...@dpdk.org > Subject: Re: [PATCH v2] net/ice: remove unnecessary variable > > Hi, Qi > > On 03/03, Qi Zhang wrote: > >Rem

Re: [dpdk-dev] [PATCH v2] net/ice: remove unnecessary variable

2020-03-03 Thread Ye Xiaolong
Hi, Qi On 03/03, Qi Zhang wrote: >Remove unnecessary variable "meta" in ice_flow_create and >ice_flow_validate, it should be defined when really be needed: >its ice_parse_engine_create and ice_parse_engine_validate. > >In a validate opertion, a meta is not necessary be created during >parser, so N

[dpdk-dev] [PATCH v2] net/ice: remove unnecessary variable

2020-03-02 Thread Qi Zhang
Remove unnecessary variable "meta" in ice_flow_create and ice_flow_validate, it should be defined when really be needed: its ice_parse_engine_create and ice_parse_engine_validate. In a validate opertion, a meta is not necessary be created during parser, so NULL will be parsed to low level engine a