Re: [dpdk-dev] [PATCH v2] net/pcap: enable data path on secondary

2018-11-13 Thread Zhang, Qi Z
> -Original Message- > From: Yigit, Ferruh > Sent: Tuesday, November 13, 2018 10:44 AM > To: Zhang, Qi Z ; Thomas Monjalon > > Cc: dev@dpdk.org; Lin, Xueqin > Subject: Re: [PATCH v2] net/pcap: enable data path on secondary > > On 11/13/2018 6:27 PM, Zhang, Qi Z wrote: > > First, apolog

Re: [dpdk-dev] [PATCH v2] net/pcap: enable data path on secondary

2018-11-13 Thread Ferruh Yigit
On 11/13/2018 6:27 PM, Zhang, Qi Z wrote: > First, apologies to make this in rush since I was somehow under pressure to > make pdump works in 18.11. > I agree there is lot of things need to improve, but the strategy here is to > make it work quietly and not break anything else :) > add some comm

Re: [dpdk-dev] [PATCH v2] net/pcap: enable data path on secondary

2018-11-13 Thread Zhang, Qi Z
First, apologies to make this in rush since I was somehow under pressure to make pdump works in 18.11. I agree there is lot of things need to improve, but the strategy here is to make it work quietly and not break anything else :) add some comments inline. > -Original Message- > From: T

Re: [dpdk-dev] [PATCH v2] net/pcap: enable data path on secondary

2018-11-13 Thread Thomas Monjalon
Just a quick comment: There are probably some ideas to take from what was done for tap. 13/11/2018 17:56, Ferruh Yigit: > On 11/12/2018 4:51 PM, Qi Zhang wrote: > > Private vdev on secondary is never supported by the new shared > > device mode but pdump still relies on a private pcap PMD on secon

Re: [dpdk-dev] [PATCH v2] net/pcap: enable data path on secondary

2018-11-13 Thread Ferruh Yigit
On 11/12/2018 4:51 PM, Qi Zhang wrote: > Private vdev on secondary is never supported by the new shared > device mode but pdump still relies on a private pcap PMD on secondary. > The patch enables pcap PMD's data path on secondary so that pdump can > work as usual. It would be great if you describ

[dpdk-dev] [PATCH v2] net/pcap: enable data path on secondary

2018-11-12 Thread Qi Zhang
Private vdev on secondary is never supported by the new shared device mode but pdump still relies on a private pcap PMD on secondary. The patch enables pcap PMD's data path on secondary so that pdump can work as usual. Signed-off-by: Qi Zhang Tested-by: Yufeng Mo --- v2: - fix init issue when