Hi Thomas,
Thanks for the review.
I did the git grep rte_net_intel_cksum_prepare and git grep
PKT_TX_OUTER_UDP_CKSUM. Following are the two drivers that use the function
to prepare headers for checksum which also uses the outer_udp_checksum
offload within drivers.
1) Hisilicon hns3
2) Wangxun t
07/07/2021 11:14, Mohsin Kazmi:
> On Wed, Jun 30, 2021 at 3:09 PM Olivier Matz wrote:
> > > + if (ol_flags & (PKT_TX_OUTER_IPV4 | PKT_TX_OUTER_IPV6)) {
> > > inner_l3_offset += m->outer_l2_len + m->outer_l3_len;
> > > + /*
> > > + * prepare outer ipv4 hea
Hi Olivier,
Thanks for the review.
Please find the comments inline below:
On Wed, Jun 30, 2021 at 3:09 PM Olivier Matz wrote:
> Hi Mohsin,
>
> Hope you are fine!
> Please see my comments below.
>
> On Wed, Jun 30, 2021 at 01:04:04PM +0200, Mohsin Kazmi wrote:
> > Re: [PATCH v2] net: prepare the
Hi Mohsin,
Hope you are fine!
Please see my comments below.
On Wed, Jun 30, 2021 at 01:04:04PM +0200, Mohsin Kazmi wrote:
> Re: [PATCH v2] net: prepare the outer ipv4 hdr for checksum
I suggest to highlight that it this is the Intel-specific tx-prepare
function in the commit title. What about:
Preparation the headers for the hardware offload
misses the outer ipv4 checksum offload.
It results in bad checksum computed by hardware NIC.
This patch fixes the issue by setting the outer ipv4
checksum field to 0.
Fixes: 4fb7e803eb1a ("ethdev: add Tx preparation")
Cc: sta...@dpdk.org
Signed-of
5 matches
Mail list logo
