[dpdk-dev] [PATCH v2] vfio: Fix overflow while assigning vfio BAR region offset and size

2015-07-10 Thread Alejandro Lucero
Hi Rahul, Go ahead. That's fine for me. Thanks On Fri, Jul 10, 2015 at 10:54 AM, Rahul Lakkireddy < rahul.lakkireddy at chelsio.com> wrote: > On Tue, Jul 07, 2015 at 10:50:23 +, Burakov, Anatoly wrote: > > Hi Rahul, > > > > > However, unsigned long seems to be working fine for all builds. >

[dpdk-dev] [PATCH v2] vfio: Fix overflow while assigning vfio BAR region offset and size

2015-07-10 Thread Rahul Lakkireddy
On Tue, Jul 07, 2015 at 10:50:23 +, Burakov, Anatoly wrote: > Hi Rahul, > > > However, unsigned long seems to be working fine for all builds. > > unsigned long it is then, if there aren't any other objections. > > Thanks, > Anatoly Hi Alejandro, Are you planning to update the original patc

[dpdk-dev] [PATCH v2] vfio: Fix overflow while assigning vfio BAR region offset and size

2015-07-07 Thread Rahul Lakkireddy
Hi Anatoly, On Tue, Jul 07, 2015 at 09:08:08 +, Burakov, Anatoly wrote: > Hi all, > > > So, as VFIO support for 32bit systems is broken, DPDK should not configure > > VFIO in that case. > > ...Or no one should try and run VFIO on a 32-bit system, which should be > noted in documentation. I

[dpdk-dev] [PATCH v2] vfio: Fix overflow while assigning vfio BAR region offset and size

2015-07-07 Thread Rahul Lakkireddy
Hi Alejandro, On Mon, Jul 06, 2015 at 16:45:01 +0100, Alejandro Lucero wrote: > Hi all, > > From the kernel VFIO maintainer: > > "I suppose in the short term, mmap should not be advertised as available > on 32bit hosts. Thanks," > > So, as VFIO support for 32bit systems is broken, DPDK should

[dpdk-dev] [PATCH v2] vfio: Fix overflow while assigning vfio BAR region offset and size

2015-07-07 Thread Burakov, Anatoly
Hi Rahul, > However, unsigned long seems to be working fine for all builds. unsigned long it is then, if there aren't any other objections. Thanks, Anatoly

[dpdk-dev] [PATCH v2] vfio: Fix overflow while assigning vfio BAR region offset and size

2015-07-07 Thread Burakov, Anatoly
Hi all, > So, as VFIO support for 32bit systems is broken, DPDK should not configure > VFIO in that case. ...Or no one should try and run VFIO on a 32-bit system, which should be noted in documentation. I'm a bit wary of adding special handling in this case. Does making the offset off_t fix th

[dpdk-dev] [PATCH v2] vfio: Fix overflow while assigning vfio BAR region offset and size

2015-07-06 Thread Alejandro Lucero
Hi all, >From the kernel VFIO maintainer: "I suppose in the short term, mmap should not be advertised as available on 32bit hosts. Thanks," So, as VFIO support for 32bit systems is broken, DPDK should not configure VFIO in that case. This is the complete email sent to the kernel maintainer and

[dpdk-dev] [PATCH v2] vfio: Fix overflow while assigning vfio BAR region offset and size

2015-07-01 Thread Burakov, Anatoly
Hi all, > The last patch from Rahul does not solve the problem. For those cases where > the MSI-X table is in one of the BARs to map, the memreg array is still in > use. Rahul's initial patch was pretty much what you have submitted, it just didn't build on a 32-bit system. > My fix was using

[dpdk-dev] [PATCH v2] vfio: Fix overflow while assigning vfio BAR region offset and size

2015-07-01 Thread Alejandro Lucero
I submitted a patch for fixing this issue on the 25th of June. I did not notice someone had reported this before. The last patch from Rahul does not solve the problem. For those cases where the MSI-X table is in one of the BARs to map, the memreg array is still in use. My fix was using unsigned lo

[dpdk-dev] [PATCH v2] vfio: Fix overflow while assigning vfio BAR region offset and size

2015-06-30 Thread Thomas Monjalon
Hi Anatoly, Please could you review this fix to allow Chelsio using VFIO? Thanks 2015-06-23 20:30, Rahul Lakkireddy: > When using vfio, the probe fails over Chelsio T5 adapters after > commit-id 90a1633b2 (eal/linux: allow to map BARs with MSI-X tables). > > While debugging further, found that th

[dpdk-dev] [PATCH v2] vfio: Fix overflow while assigning vfio BAR region offset and size

2015-06-23 Thread Rahul Lakkireddy
When using vfio, the probe fails over Chelsio T5 adapters after commit-id 90a1633b2 (eal/linux: allow to map BARs with MSI-X tables). While debugging further, found that the BAR region offset and size read from vfio are u64, but are assigned to uint32_t variables. This results in the u64 value ge