Re: [dpdk-dev] [PATCH v2] vhost: batch used descs chains write-back with packed ring

2018-12-20 Thread Michael S. Tsirkin
On Thu, Dec 20, 2018 at 12:44:46PM +0800, Tiwei Bie wrote: > On Wed, Dec 19, 2018 at 10:29:52AM +0100, Maxime Coquelin wrote: > > Instead of writing back descriptors chains in order, let's > > write the first chain flags last in order to improve batching. > > > > With Kernel's pktgen benchmark, ~3

Re: [dpdk-dev] [PATCH v2] vhost: batch used descs chains write-back with packed ring

2018-12-20 Thread Maxime Coquelin
On 12/20/18 9:49 AM, Maxime Coquelin wrote: On 12/20/18 5:44 AM, Tiwei Bie wrote: On Wed, Dec 19, 2018 at 10:29:52AM +0100, Maxime Coquelin wrote: Instead of writing back descriptors chains in order, let's write the first chain flags last in order to improve batching. With Kernel's pktgen

Re: [dpdk-dev] [PATCH v2] vhost: batch used descs chains write-back with packed ring

2018-12-20 Thread Maxime Coquelin
On 12/20/18 5:44 AM, Tiwei Bie wrote: On Wed, Dec 19, 2018 at 10:29:52AM +0100, Maxime Coquelin wrote: Instead of writing back descriptors chains in order, let's write the first chain flags last in order to improve batching. With Kernel's pktgen benchmark, ~3% performance gain is measured.

Re: [dpdk-dev] [PATCH v2] vhost: batch used descs chains write-back with packed ring

2018-12-19 Thread Tiwei Bie
On Wed, Dec 19, 2018 at 10:29:52AM +0100, Maxime Coquelin wrote: > Instead of writing back descriptors chains in order, let's > write the first chain flags last in order to improve batching. > > With Kernel's pktgen benchmark, ~3% performance gain is measured. > > Signed-off-by: Maxime Coquelin

Re: [dpdk-dev] [PATCH v2] vhost: batch used descs chains write-back with packed ring

2018-12-19 Thread Michael S. Tsirkin
On Wed, Dec 19, 2018 at 10:29:52AM +0100, Maxime Coquelin wrote: > Instead of writing back descriptors chains in order, let's > write the first chain flags last in order to improve batching. > > With Kernel's pktgen benchmark, ~3% performance gain is measured. > > Signed-off-by: Maxime Coquelin

[dpdk-dev] [PATCH v2] vhost: batch used descs chains write-back with packed ring

2018-12-19 Thread Maxime Coquelin
Instead of writing back descriptors chains in order, let's write the first chain flags last in order to improve batching. With Kernel's pktgen benchmark, ~3% performance gain is measured. Signed-off-by: Maxime Coquelin --- V2: Revert back to initial implementation to have a write barrier before