[dpdk-dev] [PATCH v2] vhost: flush used->idx update before reading avail->flags

2015-05-18 Thread Nikita Kalyazin
Ah, sorry. I looked at it without the context. Thanks. -- Best regards, Nikita Kalyazin, n.kalyazin at samsung.com Software Engineer CE OS Group Samsung R&D Institute Russia Tel: +7 (495) 797-25-00 #3816 Tel: +7 (495) 797-25-03 Office #1501, 12-1, Dvintsev str., Moscow, 127018, Russia On Fri,

[dpdk-dev] [PATCH v2] vhost: flush used->idx update before reading avail->flags

2015-05-15 Thread Michael S. Tsirkin
On Fri, May 15, 2015 at 04:43:33PM +0300, Nikita Kalyazin wrote: > Hi, > > > Maybe I missed a part of the discussion, but is there any special purpose for > using rte_mb (both read and write fence) here rather than rte_wmb (write > fence only)? The fence is between write of used->idx and read

[dpdk-dev] [PATCH v2] vhost: flush used->idx update before reading avail->flags

2015-05-15 Thread Nikita Kalyazin
Hi, Maybe I missed a part of the discussion, but is there any special purpose for using rte_mb (both read and write fence) here rather than rte_wmb (write fence only)? -- Best regards, Nikita Kalyazin, n.kalyazin at samsung.com Software Engineer CE OS Group Samsung R&D Institute Russia Tel

[dpdk-dev] [PATCH v2] vhost: flush used->idx update before reading avail->flags

2015-05-13 Thread Thomas Monjalon
2015-04-29 19:11, Huawei Xie: > update of used->idx and read of avail->flags could be reordered. > memory fence should be used to ensure the order, otherwise guest could see a > stale used->idx value after it toggles the interrupt suppression flag. > After guest sets the interrupt suppression flag

[dpdk-dev] [PATCH v2] vhost: flush used->idx update before reading avail->flags

2015-04-29 Thread Huawei Xie
update of used->idx and read of avail->flags could be reordered. memory fence should be used to ensure the order, otherwise guest could see a stale used->idx value after it toggles the interrupt suppression flag. After guest sets the interrupt suppression flag, it will check if there is more buff