Re: [dpdk-dev] [PATCH v2 0/7] crypto/security session framework rework

2021-10-16 Thread Zhang, Roy Fan
Hi, > -Original Message- > From: Akhil Goyal > Sent: Friday, October 15, 2021 7:47 PM > To: Zhang, Roy Fan ; dev@dpdk.org > Cc: tho...@monjalon.net; david.march...@redhat.com; > hemant.agra...@nxp.com; Anoob Joseph ; De Lara > Guarch, Pablo ; Trahe, Fiona > ; Doherty, Declan ; > ma...@nvi

Re: [dpdk-dev] [PATCH v2 0/7] crypto/security session framework rework

2021-10-16 Thread Zhang, Roy Fan
Hi Akhil, I didn't work on the asym problem. As stated in the email I could think of the solution is to add new API to create asym session pool - or you may have better solution. BTW current test_cryptodev_asym.c the function testsuite_setup() creates the queue pair before creating the sessio

Re: [dpdk-dev] [PATCH v2 0/7] crypto/security session framework rework

2021-10-15 Thread Akhil Goyal
> > Hi Akhil, > > > > I tried to fix the problems of seg faults. > > The seg-faults are gone now but all asym tests are failing too. > > The reason is the rte_cryptodev_queue_pair_setup() checks the session > > mempool same for sym and asym. > > Since we don't have a rte_cryptodev_asym_session_pool

Re: [dpdk-dev] [PATCH v2 0/7] crypto/security session framework rework

2021-10-15 Thread Akhil Goyal
> Hi Akhil, > > I tried to fix the problems of seg faults. > The seg-faults are gone now but all asym tests are failing too. > The reason is the rte_cryptodev_queue_pair_setup() checks the session > mempool same for sym and asym. > Since we don't have a rte_cryptodev_asym_session_pool_create() the

Re: [dpdk-dev] [PATCH v2 0/7] crypto/security session framework rework

2021-10-15 Thread Zhang, Roy Fan
Hi Akhil, I tried to fix the problems of seg faults. The seg-faults are gone now but all asym tests are failing too. The reason is the rte_cryptodev_queue_pair_setup() checks the session mempool same for sym and asym. Since we don't have a rte_cryptodev_asym_session_pool_create() the session mem

Re: [dpdk-dev] [PATCH v2 0/7] crypto/security session framework rework

2021-10-15 Thread Zhang, Roy Fan
Hi Akhil, It shall work but Kasumi tests are passing :-) It is snow3g and aesni-mb/gcm that are failing. Thanks Regards, Fan > -Original Message- > From: Akhil Goyal > Sent: Thursday, October 14, 2021 7:24 PM > To: Zhang, Roy Fan ; dev@dpdk.org > Cc: tho...@monjalon.net; david.march...@

Re: [dpdk-dev] [PATCH v2 0/7] crypto/security session framework rework

2021-10-14 Thread Akhil Goyal
Hi Fan, Check for below QAT fix also > > > > Unfortunately the patches still cause seg-fault at QAT and SW PMDs. > > > > - for qat it fails at rte_security_ops->session_size_get not implemented. And for this one diff --git a/drivers/crypto/qat/qat_sym_pmd.c b/drivers/crypto/qat/qat_sym_pmd.c index

Re: [dpdk-dev] [PATCH v2 0/7] crypto/security session framework rework

2021-10-14 Thread Akhil Goyal
Hi Fan, > > Unfortunately the patches still cause seg-fault at QAT and SW PMDs. > > - for qat it fails at rte_security_ops->session_size_get not implemented. > - for sw pmds the queue pair's session private mempools are not set. > Can you check if below change works for Kasumi. I will replicate

Re: [dpdk-dev] [PATCH v2 0/7] crypto/security session framework rework

2021-10-14 Thread Zhang, Roy Fan
Hi, Unfortunately the patches still cause seg-fault at QAT and SW PMDs. - for qat it fails at rte_security_ops->session_size_get not implemented. - for sw pmds the queue pair's session private mempools are not set. Regards, Fan > -Original Message- > From: Akhil Goyal > Sent: Thursday,

Re: [dpdk-dev] [PATCH v2 0/7] crypto/security session framework rework

2021-10-14 Thread Akhil Goyal
> Hi Akhil, > > The series 19519 will make multi-process case not working for all crypto > PMDs. > Please provide a solution first. > Yes I am working on it, will update the series asap.

Re: [dpdk-dev] [PATCH v2 0/7] crypto/security session framework rework

2021-10-14 Thread Zhang, Roy Fan
Hi Akhil, > -Original Message- > From: Akhil Goyal > Sent: Thursday, October 14, 2021 12:48 PM > To: Akhil Goyal ; dev@dpdk.org > Cc: tho...@monjalon.net; david.march...@redhat.com; > hemant.agra...@nxp.com; Anoob Joseph ; De Lara > Guarch, Pablo ; Trahe, Fiona > ; Doherty, Declan ; > ma.

Re: [dpdk-dev] [PATCH v2 0/7] crypto/security session framework rework

2021-10-14 Thread Akhil Goyal
> Subject: [PATCH v2 0/7] crypto/security session framework rework > > As discussed in last release deprecation notice, > crypto and security session framework are reworked > to reduce the need of two mempool objects and > remove the requirement to expose the rte_security_session > and rte_cryptod

[dpdk-dev] [PATCH v2 0/7] crypto/security session framework rework

2021-10-13 Thread Akhil Goyal
As discussed in last release deprecation notice, crypto and security session framework are reworked to reduce the need of two mempool objects and remove the requirement to expose the rte_security_session and rte_cryptodev_sym_session structures. Design methodology is explained in the patch descript