Re: [dpdk-dev] [PATCH v2 02/20] net/ice: support device initialization

2018-12-12 Thread Varghese, Vipin
From: Zhang, Qi Z > > Sent: Thursday, December 6, 2018 3:46 PM > > To: Lu, Wenzhuo ; Varghese, Vipin > > > > Cc: Yigit, Ferruh ; Zhang, Helin > > ; Xu, Qian Q > > Subject: RE: [dpdk-dev] [PATCH v2 02/20] net/ice: support device > > initialization > &

Re: [dpdk-dev] [PATCH v2 02/20] net/ice: support device initialization

2018-12-05 Thread Lu, Wenzhuo
Hi Vipin, > -Original Message- > From: Varghese, Vipin > Sent: Thursday, December 6, 2018 2:31 PM > To: Lu, Wenzhuo ; dev@dpdk.org > Cc: Yang, Qiming ; Li, Xiaoyun > ; Wu, Jingjing > Subject: RE: [dpdk-dev] [PATCH v2 02/20] net/ice: support device > ini

Re: [dpdk-dev] [PATCH v2 02/20] net/ice: support device initialization

2018-12-05 Thread Varghese, Vipin
snipped > > > > > + ice_init_controlq_parameter(hw); > > > > > + > > > > > + ret = ice_init_hw(hw); > > > > > + if (ret) { > > > > > + PMD_INIT_LOG(ERR, "Failed to initialize HW"); > > > > > + return -EINVAL; > > > > > + } > > > > > > > > Definition for ice_i

Re: [dpdk-dev] [PATCH v2 02/20] net/ice: support device initialization

2018-12-05 Thread Lu, Wenzhuo
Hi Vipin, > -Original Message- > From: Varghese, Vipin > Sent: Thursday, December 6, 2018 1:33 PM > To: Lu, Wenzhuo ; dev@dpdk.org > Cc: Yang, Qiming ; Li, Xiaoyun > ; Wu, Jingjing > Subject: RE: [dpdk-dev] [PATCH v2 02/20] net/ice: support device > ini

Re: [dpdk-dev] [PATCH v2 02/20] net/ice: support device initialization

2018-12-05 Thread Varghese, Vipin
snipped > > > + ice_init_controlq_parameter(hw); > > > + > > > + ret = ice_init_hw(hw); > > > + if (ret) { > > > + PMD_INIT_LOG(ERR, "Failed to initialize HW"); > > > + return -EINVAL; > > > + } > > > > Definition for ice_init_hw in patch 01/20 does not check for primary- > > second

Re: [dpdk-dev] [PATCH v2 02/20] net/ice: support device initialization

2018-12-05 Thread Lu, Wenzhuo
Hi Vipin, > -Original Message- > From: Varghese, Vipin > Sent: Tuesday, December 4, 2018 12:41 PM > To: Lu, Wenzhuo ; dev@dpdk.org > Cc: Lu, Wenzhuo ; Yang, Qiming > ; Li, Xiaoyun ; Wu, Jingjing > > Subject: RE: [dpdk-dev] [PATCH v2 02/20] net/ice: support

Re: [dpdk-dev] [PATCH v2 02/20] net/ice: support device initialization

2018-12-03 Thread Varghese, Vipin
Snipped > + /* Set the info.ingress_table and info.egress_table > + * for UP translate table. Now just set it to 1:1 map by default > + * -- 0b 111 110 101 100 011 010 001 000 == 0xFAC688 > + */ > + info->ingress_table = rte_cpu_to_le_32(0x00FAC688); > + info->egress_

Re: [dpdk-dev] [PATCH v2 02/20] net/ice: support device initialization

2018-12-03 Thread Varghese, Vipin
Hi, snipped > +# Compile burst-oriented ICE PMD driver # CONFIG_RTE_LIBRTE_ICE_PMD=y Based on ' https://patches.dpdk.org/patch/48488/' it is suggested to configure. But here is it already set to 'y'. Is this correct? If yes can you update ' https://patches.dpdk.org/patch/48488/' snipped

[dpdk-dev] [PATCH v2 02/20] net/ice: support device initialization

2018-12-02 Thread Wenzhuo Lu
Signed-off-by: Wenzhuo Lu Signed-off-by: Qiming Yang Signed-off-by: Xiaoyun Li Signed-off-by: Jingjing Wu --- config/common_base | 9 + drivers/net/Makefile| 1 + drivers/net/ice/Makefile| 75 drivers/net/ice/ice_ethdev.c