Re: [dpdk-dev] [PATCH v2 1/1] build: enable BSD features visibility for FreeBSD

2019-06-26 Thread Thomas Monjalon
> > When a component uses either XOPEN_SOURCE or POSIX_C_SOURCE macro > > explicitly in its build recipe, it restricts visibility of a non POSIX > > features subset, such as IANA protocol numbers (IPPROTO_* macros). > > Non standard features are enabled by default for DPDK both for Linux > > thanks

Re: [dpdk-dev] [PATCH v2 1/1] build: enable BSD features visibility for FreeBSD

2019-06-17 Thread Smoczynski, MarcinX
Is my action required to merge patches? e.g. do I need to send rebased patches (however there are no conflicts at the moment)? > -Original Message- > From: Ananyev, Konstantin > Sent: Wednesday, June 5, 2019 12:16 PM > To: Smoczynski, MarcinX ; Richardson, > Bruce ; tho...@monjalon.net >

Re: [dpdk-dev] [PATCH v2 1/1] build: enable BSD features visibility for FreeBSD

2019-06-05 Thread Ananyev, Konstantin
> > When a component uses either XOPEN_SOURCE or POSIX_C_SOURCE macro > explicitly in its build recipe, it restricts visibility of a non POSIX > features subset, such as IANA protocol numbers (IPPROTO_* macros). > Non standard features are enabled by default for DPDK both for Linux > thanks to _

Re: [dpdk-dev] [PATCH v2 1/1] build: enable BSD features visibility for FreeBSD

2019-06-05 Thread Bruce Richardson
On Wed, Jun 05, 2019 at 11:37:34AM +0200, Thomas Monjalon wrote: > Marcin, please remind to use --in-reply-to to have next versions > in the same thread. Thanks > > Bruce, Konstantin, Adrien, any opinion about this patch? > Looks a reasonable cleanup to me. The fact that the same macros are being

Re: [dpdk-dev] [PATCH v2 1/1] build: enable BSD features visibility for FreeBSD

2019-06-05 Thread Thomas Monjalon
Marcin, please remind to use --in-reply-to to have next versions in the same thread. Thanks Bruce, Konstantin, Adrien, any opinion about this patch? 14/05/2019 16:04, Marcin Smoczynski: > When a component uses either XOPEN_SOURCE or POSIX_C_SOURCE macro > explicitly in its build recipe, it restr

[dpdk-dev] [PATCH v2 1/1] build: enable BSD features visibility for FreeBSD

2019-05-14 Thread Marcin Smoczynski
When a component uses either XOPEN_SOURCE or POSIX_C_SOURCE macro explicitly in its build recipe, it restricts visibility of a non POSIX features subset, such as IANA protocol numbers (IPPROTO_* macros). Non standard features are enabled by default for DPDK both for Linux thanks to _GNU_SOURCE and