Re: [dpdk-dev] [PATCH v2 1/1] net: fix aliasing issue in checksum computation

2021-10-18 Thread Ferruh Yigit
On 10/18/2021 8:58 AM, Olivier Matz wrote: On Mon, Oct 18, 2021 at 09:35:41AM +0200, Morten Brørup wrote: From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Georg Sauthoff Sent: Sunday, 17 October 2021 22.37 +Ferruh, as delegate to v1 in Patchwork. That means a superfluous cast is removed

Re: [dpdk-dev] [PATCH v2 1/1] net: fix aliasing issue in checksum computation

2021-10-18 Thread Olivier Matz
On Mon, Oct 18, 2021 at 09:35:41AM +0200, Morten Brørup wrote: > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Georg Sauthoff > > Sent: Sunday, 17 October 2021 22.37 > > +Ferruh, as delegate to v1 in Patchwork. > > > > > That means a superfluous cast is removed and aliasing through a ui

Re: [dpdk-dev] [PATCH v2 1/1] net: fix aliasing issue in checksum computation

2021-10-18 Thread Morten Brørup
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Georg Sauthoff > Sent: Sunday, 17 October 2021 22.37 +Ferruh, as delegate to v1 in Patchwork. > > That means a superfluous cast is removed and aliasing through a uint8_t > pointer is eliminated. NB: The C standard specifies that a unsigned >

[dpdk-dev] [PATCH v2 1/1] net: fix aliasing issue in checksum computation

2021-10-17 Thread Georg Sauthoff
That means a superfluous cast is removed and aliasing through a uint8_t pointer is eliminated. NB: The C standard specifies that a unsigned char pointer may alias while the C standard doesn't include such requirement for uint8_t pointers. Also simplified the loop since a modern C compiler can spee