[dpdk-dev] [PATCH v2 1/2] Added ETH_SPEED_CAP bitmap in rte_eth_dev_info

2015-06-18 Thread Thomas Monjalon
2015-06-18 17:06, Marc Sune: > On 18/06/15 16:43, Morten Br?rup wrote: > > Regarding the PHY speed ABI: > > > > 1. The Ethernet PHY ABI for speed, duplex, etc. should be common throughout > > the entire DPDK. It might be confusing if some structures/functions use a > > bitmask to indicate PHY

[dpdk-dev] [PATCH v2 1/2] Added ETH_SPEED_CAP bitmap in rte_eth_dev_info

2015-06-18 Thread Marc Sune
On 18/06/15 16:43, Morten Br?rup wrote: > Regarding the PHY speed ABI: > > > > 1. The Ethernet PHY ABI for speed, duplex, etc. should be common throughout > the entire DPDK. It might be confusing if some structures/functions use a > bitmask to indicate PHY speed/duplex/personality/etc. and

[dpdk-dev] [PATCH v2 1/2] Added ETH_SPEED_CAP bitmap in rte_eth_dev_info

2015-06-18 Thread Morten Brørup
Regarding the PHY speed ABI: 1. The Ethernet PHY ABI for speed, duplex, etc. should be common throughout the entire DPDK. It might be confusing if some structures/functions use a bitmask to indicate PHY speed/duplex/personality/etc. and other structures/functions use a combination of an

[dpdk-dev] [PATCH v2 1/2] Added ETH_SPEED_CAP bitmap in rte_eth_dev_info

2015-06-11 Thread Marc Sune
On 11/06/15 11:08, Thomas Monjalon wrote: > 2015-06-08 10:50, Marc Sune: >> On 29/05/15 20:23, Thomas Monjalon wrote: >>> 2015-05-27 11:15, Marc Sune: On 27/05/15 06:02, Thomas Monjalon wrote: >> +#define ETH_SPEED_CAP_10M_HD(1 << 0) /*< 10 Mbps half-duplex> */ >> +#define

[dpdk-dev] [PATCH v2 1/2] Added ETH_SPEED_CAP bitmap in rte_eth_dev_info

2015-06-11 Thread Thomas Monjalon
2015-06-08 10:50, Marc Sune: > On 29/05/15 20:23, Thomas Monjalon wrote: > > 2015-05-27 11:15, Marc Sune: > >> On 27/05/15 06:02, Thomas Monjalon wrote: > +#define ETH_SPEED_CAP_10M_HD(1 << 0) /*< 10 Mbps half-duplex> */ > +#define ETH_SPEED_CAP_10M_FD(1 << 1) /*< 10 Mbps

[dpdk-dev] [PATCH v2 1/2] Added ETH_SPEED_CAP bitmap in rte_eth_dev_info

2015-06-08 Thread Marc Sune
On 29/05/15 20:23, Thomas Monjalon wrote: > 2015-05-27 11:15, Marc Sune: >> On 27/05/15 06:02, Thomas Monjalon wrote: >>> Why not starting with lower values? Some new drivers may be interested >>> by lower speed. >> Ok, but which values? 1Mbps FD/HD? Even lower than that? >> >> If you have some

[dpdk-dev] [PATCH v2 1/2] Added ETH_SPEED_CAP bitmap in rte_eth_dev_info

2015-05-29 Thread Thomas Monjalon
2015-05-27 11:15, Marc Sune: > On 27/05/15 06:02, Thomas Monjalon wrote: > > Why not starting with lower values? Some new drivers may be interested > > by lower speed. > > Ok, but which values? 1Mbps FD/HD? Even lower than that? > > If you have some NIC(s) in mind with lower values, please point

[dpdk-dev] [PATCH v2 1/2] Added ETH_SPEED_CAP bitmap in rte_eth_dev_info

2015-05-27 Thread Marc Sune
On 27/05/15 06:02, Thomas Monjalon wrote: > Hi Marc, > > 2015-05-26 21:50, Marc Sune: >> Added constants and bitmap to struct rte_eth_dev_info to be used by PMDs. >> >> Signed-off-by: Marc Sune > [...] >> +/** >> + * Device supported speeds >> + */ >> +#define ETH_SPEED_CAP_NOT_PHY (0)

[dpdk-dev] [PATCH v2 1/2] Added ETH_SPEED_CAP bitmap in rte_eth_dev_info

2015-05-27 Thread Thomas Monjalon
Hi Marc, 2015-05-26 21:50, Marc Sune: > Added constants and bitmap to struct rte_eth_dev_info to be used by PMDs. > > Signed-off-by: Marc Sune [...] > +/** > + * Device supported speeds > + */ > +#define ETH_SPEED_CAP_NOT_PHY(0) /*< No phy media > */ Why not starting with lower

[dpdk-dev] [PATCH v2 1/2] Added ETH_SPEED_CAP bitmap in rte_eth_dev_info

2015-05-26 Thread Marc Sune
Added constants and bitmap to struct rte_eth_dev_info to be used by PMDs. Signed-off-by: Marc Sune --- lib/librte_ether/rte_ethdev.h | 24 1 file changed, 24 insertions(+) diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h index 16dbe00..f57676b