Re: [dpdk-dev] [PATCH v2 1/2] app/testpmd: add VXLAN encap/decap support

2018-06-19 Thread NĂ©lio Laranjeiro
On Mon, Jun 18, 2018 at 02:02:10PM -0700, Stephen Hemminger wrote: > On Mon, 18 Jun 2018 10:52:54 +0200 > Nelio Laranjeiro wrote: > > > > > +struct vxlan_encap_conf vxlan_encap_conf = { > > + .select_ipv4 = 1, > > + .vni = "\x00\x00\x00", > > + .udp_src = RTE_BE16(1), > > Overall looks g

Re: [dpdk-dev] [PATCH v2 1/2] app/testpmd: add VXLAN encap/decap support

2018-06-18 Thread Stephen Hemminger
On Mon, 18 Jun 2018 10:52:54 +0200 Nelio Laranjeiro wrote: > > +struct vxlan_encap_conf vxlan_encap_conf = { > + .select_ipv4 = 1, > + .vni = "\x00\x00\x00", > + .udp_src = RTE_BE16(1), Overall looks good. One enhancement I would suggest is to implement generating the UDP source po

Re: [dpdk-dev] [PATCH v2 1/2] app/testpmd: add VXLAN encap/decap support

2018-06-18 Thread Mohammad Abdul Awal
Hi Nelio, On 18/06/2018 09:52, Nelio Laranjeiro wrote: Due to the complex VXLAN_ENCAP flow action and based on the fact testpmd does not allocate memory, this patch adds a new command in testpmd to initialise a global structure containing the necessary information to make the outer layer of the

[dpdk-dev] [PATCH v2 1/2] app/testpmd: add VXLAN encap/decap support

2018-06-18 Thread Nelio Laranjeiro
Due to the complex VXLAN_ENCAP flow action and based on the fact testpmd does not allocate memory, this patch adds a new command in testpmd to initialise a global structure containing the necessary information to make the outer layer of the packet. This same global structure will then be used by t