Re: [dpdk-dev] [PATCH v2 1/2] ethdev: extend RSS offload types

2019-09-25 Thread Su, Simei
> -Original Message- > From: Ye, Xiaolong > Sent: Wednesday, September 25, 2019 8:24 PM > To: Su, Simei > Cc: Zhang, Qi Z ; Wu, Jingjing ; > dev@dpdk.org > Subject: Re: [PATCH v2 1/2] ethdev: extend RSS offload types > > On 09/25, Su, Simei wrote: > >> >+/* > >> >+ * We use the followi

Re: [dpdk-dev] [PATCH v2 1/2] ethdev: extend RSS offload types

2019-09-25 Thread Su, Simei
> -Original Message- > From: Ye, Xiaolong > Sent: Wednesday, September 25, 2019 8:23 PM > To: Su, Simei > Cc: Zhang, Qi Z ; Wu, Jingjing ; > dev@dpdk.org > Subject: Re: [PATCH v2 1/2] ethdev: extend RSS offload types > > On 09/25, Su, Simei wrote: > >Hi, xiaolong > > > >> -Original

Re: [dpdk-dev] [PATCH v2 1/2] ethdev: extend RSS offload types

2019-09-25 Thread Ye Xiaolong
On 09/25, Su, Simei wrote: >> >+/* >> >+ * We use the following macros to combine with above ETH_RSS_* for >> >+ * more specific input set selection. These bits are defined starting >> >+ * from the bottom of the 64 bits. >> >> s/bottom/high end/ > > Sorry, what does it mean, I didn't understand i

Re: [dpdk-dev] [PATCH v2 1/2] ethdev: extend RSS offload types

2019-09-25 Thread Ye Xiaolong
On 09/25, Su, Simei wrote: >Hi, xiaolong > >> -Original Message- >> From: Ye, Xiaolong >> Sent: Wednesday, September 25, 2019 6:50 PM >> To: Su, Simei >> Cc: Zhang, Qi Z ; Wu, Jingjing ; >> dev@dpdk.org >> Subject: Re: [PATCH v2 1/2] ethdev: extend RSS offload types >> >> On 09/23, Simei

Re: [dpdk-dev] [PATCH v2 1/2] ethdev: extend RSS offload types

2019-09-25 Thread Su, Simei
Hi, xiaolong > -Original Message- > From: Ye, Xiaolong > Sent: Wednesday, September 25, 2019 6:28 PM > To: Su, Simei > Cc: Zhang, Qi Z ; Wu, Jingjing ; > dev@dpdk.org > Subject: Re: [PATCH v2 1/2] ethdev: extend RSS offload types > > On 09/23, Simei Su wrote: > >This patch cover two aspe

Re: [dpdk-dev] [PATCH v2 1/2] ethdev: extend RSS offload types

2019-09-25 Thread Su, Simei
Hi, xiaolong > -Original Message- > From: Ye, Xiaolong > Sent: Wednesday, September 25, 2019 6:50 PM > To: Su, Simei > Cc: Zhang, Qi Z ; Wu, Jingjing ; > dev@dpdk.org > Subject: Re: [PATCH v2 1/2] ethdev: extend RSS offload types > > On 09/23, Simei Su wrote: > >This patch cover two aspe

Re: [dpdk-dev] [PATCH v2 1/2] ethdev: extend RSS offload types

2019-09-25 Thread Ye Xiaolong
On 09/23, Simei Su wrote: >This patch cover two aspects: > (1)decouple RTE_ETH_FLOW_* and ETH_RSS_*. Because both serve > different purposes. > > (2)reserve several bits as input set selection from bottom > of the 64 bits. It is combined with exisiting ETH_RSS_* to > represent rss typ

Re: [dpdk-dev] [PATCH v2 1/2] ethdev: extend RSS offload types

2019-09-25 Thread Ye Xiaolong
On 09/23, Simei Su wrote: >This patch cover two aspects: > (1)decouple RTE_ETH_FLOW_* and ETH_RSS_*. Because both serve > different purposes. I saw in the comment of flow types definition "Note that the flow types are used to define RSS offload types". We need to remove it if we do the dec

[dpdk-dev] [PATCH v2 1/2] ethdev: extend RSS offload types

2019-09-23 Thread Simei Su
This patch cover two aspects: (1)decouple RTE_ETH_FLOW_* and ETH_RSS_*. Because both serve different purposes. (2)reserve several bits as input set selection from bottom of the 64 bits. It is combined with exisiting ETH_RSS_* to represent rss types. for example: ETH_RSS_I