Re: [dpdk-dev] [PATCH v2 1/2] net/fm10k: convert to new Rx offloads API

2018-04-04 Thread Ferruh Yigit
On 4/3/2018 11:48 AM, Ananyev, Konstantin wrote: > > >> -Original Message- >> From: Dai, Wei >> Sent: Tuesday, April 3, 2018 8:11 AM >> To: Ananyev, Konstantin ; Zhang, Qi Z >> ; Wang, Xiao W >> Cc: 'dev@dpdk.org' >> Subject:

Re: [dpdk-dev] [PATCH v2 1/2] net/fm10k: convert to new Rx offloads API

2018-04-03 Thread Ananyev, Konstantin
> -Original Message- > From: Dai, Wei > Sent: Tuesday, April 3, 2018 8:11 AM > To: Ananyev, Konstantin ; Zhang, Qi Z > ; Wang, Xiao W > Cc: 'dev@dpdk.org' > Subject: RE: [dpdk-dev] [PATCH v2 1/2] net/fm10k: convert to new Rx offloads > API >

Re: [dpdk-dev] [PATCH v2 1/2] net/fm10k: convert to new Rx offloads API

2018-04-03 Thread Dai, Wei
no matter whether SCATTER is enabled on queue configuration or not. > -Original Message- > From: Ananyev, Konstantin > Sent: Sunday, April 1, 2018 8:09 PM > To: Zhang, Qi Z ; Dai, Wei ; > Wang, Xiao W > Cc: 'dev@dpdk.org' > Subject: RE: [dpdk-dev] [PATCH

Re: [dpdk-dev] [PATCH v2 1/2] net/fm10k: convert to new Rx offloads API

2018-04-01 Thread Ananyev, Konstantin
Hi Qi, > > > > > > > > > > > > Hi Daiwei: > > > > > > > > > > > > > +static uint64_t fm10k_get_rx_queue_offloads_capa(struct > > > > > > > +rte_eth_dev > > > > > > > +*dev) { > > > > > > > + RTE_SET_USED(dev); > > > > > > > + > > > > > > > + return (uint64_t)(DEV_RX_OFFLOAD_SCATTER); > > > > > > >

Re: [dpdk-dev] [PATCH v2 1/2] net/fm10k: convert to new Rx offloads API

2018-03-29 Thread Zhang, Qi Z
> -Original Message- > From: Ananyev, Konstantin > Sent: Thursday, March 29, 2018 6:21 PM > To: Zhang, Qi Z ; Dai, Wei ; Wang, > Xiao W > Cc: 'dev@dpdk.org' > Subject: RE: [dpdk-dev] [PATCH v2 1/2] net/fm10k: convert to new Rx > offloads API >

Re: [dpdk-dev] [PATCH v2 1/2] net/fm10k: convert to new Rx offloads API

2018-03-29 Thread Ananyev, Konstantin
Hi Qi, > -Original Message- > From: Zhang, Qi Z > Sent: Thursday, March 29, 2018 10:51 AM > To: Ananyev, Konstantin ; Dai, Wei > ; Wang, Xiao W > Cc: 'dev@dpdk.org' > Subject: RE: [dpdk-dev] [PATCH v2 1/2] net/fm10k: convert to new Rx off

Re: [dpdk-dev] [PATCH v2 1/2] net/fm10k: convert to new Rx offloads API

2018-03-29 Thread Zhang, Qi Z
Hi Konstantin: > -Original Message- > From: Ananyev, Konstantin > Sent: Thursday, March 29, 2018 5:29 PM > To: Zhang, Qi Z ; Dai, Wei ; Wang, > Xiao W > Cc: 'dev@dpdk.org' > Subject: RE: [dpdk-dev] [PATCH v2 1/2] net/fm10k: convert to new Rx > offlo

Re: [dpdk-dev] [PATCH v2 1/2] net/fm10k: convert to new Rx offloads API

2018-03-29 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Zhang, Qi Z > Sent: Thursday, March 29, 2018 7:09 AM > To: Dai, Wei ; Wang, Xiao W > Cc: 'dev@dpdk.org' > Subject: Re: [dpdk-dev] [PATCH v2 1/2] net/fm10k: conve

Re: [dpdk-dev] [PATCH v2 1/2] net/fm10k: convert to new Rx offloads API

2018-03-28 Thread Zhang, Qi Z
> -Original Message- > From: Zhang, Qi Z > Sent: Wednesday, March 28, 2018 6:08 PM > To: Dai, Wei ; Wang, Xiao W > Cc: dev@dpdk.org > Subject: RE: [PATCH v2 1/2] net/fm10k: convert to new Rx offloads API > > Hi Daiwei: > > > +static uint64_t fm10k_get_rx_queue_offloads_capa(struct rte_

Re: [dpdk-dev] [PATCH v2 1/2] net/fm10k: convert to new Rx offloads API

2018-03-28 Thread Zhang, Qi Z
Hi Daiwei: > +static uint64_t fm10k_get_rx_queue_offloads_capa(struct rte_eth_dev > +*dev) { > + RTE_SET_USED(dev); > + > + return (uint64_t)(DEV_RX_OFFLOAD_SCATTER); > +} why per queue rx scattered feature here? My understanding is either we use scattered rx function that enable this fe

[dpdk-dev] [PATCH v2 1/2] net/fm10k: convert to new Rx offloads API

2018-03-28 Thread Wei Dai
Ethdev Rx offloads API has changed since: commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API") This commit support the new Rx offloads API. Signed-off-by: Wei Dai --- drivers/net/fm10k/fm10k.h | 1 + drivers/net/fm10k/fm10k_ethdev.c | 88 +--