Re: [dpdk-dev] [PATCH v2 1/2] test/hash: use existing lcore API

2019-05-28 Thread Dharmik Thakkar
> On May 27, 2019, at 5:15 AM, David Marchand wrote: > > Hello Dharmik, Hi David, > > On Wed, May 22, 2019 at 9:38 PM Dharmik Thakkar > wrote: > > On May 22, 2019, at 12:17 PM, David Marchand > > wrote: > > On Wed, May 22, 2019 at 6:27 PM Dharmik Thakkar > > wrote: > > > @@ -738,10 +736

Re: [dpdk-dev] [PATCH v2 1/2] test/hash: use existing lcore API

2019-05-27 Thread David Marchand
Hello Dharmik, On Wed, May 22, 2019 at 9:38 PM Dharmik Thakkar wrote: > > On May 22, 2019, at 12:17 PM, David Marchand > wrote: > > On Wed, May 22, 2019 at 6:27 PM Dharmik Thakkar > wrote: > > > @@ -738,10 +736,9 @@ struct { > > > rte_eal_remote_launch(test_rwc_re

Re: [dpdk-dev] [PATCH v2 1/2] test/hash: use existing lcore API

2019-05-23 Thread Maxime Coquelin
On 5/22/19 5:06 PM, David Marchand wrote: Prefer the existing apis rather than direct access the configuration structure. test_hash_multi_add_lookup() currently starts n readers and N writers using rte_eal_remote_launch(). It then waits for the N writers to complete with a custom multi_writer

Re: [dpdk-dev] [PATCH v2 1/2] test/hash: use existing lcore API

2019-05-22 Thread Dharmik Thakkar
> On May 22, 2019, at 12:17 PM, David Marchand > wrote: > > Hello Dharmik, > > On Wed, May 22, 2019 at 6:27 PM Dharmik Thakkar > wrote: > > On May 22, 2019, at 10:06 AM, David Marchand > > wrote: > > > > Prefer the existing apis rather than direct access the configuration > > structure.

Re: [dpdk-dev] [PATCH v2 1/2] test/hash: use existing lcore API

2019-05-22 Thread David Marchand
Hello Dharmik, On Wed, May 22, 2019 at 6:27 PM Dharmik Thakkar wrote: > > On May 22, 2019, at 10:06 AM, David Marchand > wrote: > > > > Prefer the existing apis rather than direct access the configuration > > structure. > > > > test_hash_multi_add_lookup() currently starts n readers and N write

Re: [dpdk-dev] [PATCH v2 1/2] test/hash: use existing lcore API

2019-05-22 Thread Dharmik Thakkar
Hi David, Thank you for the patch! Some comments inlined. > On May 22, 2019, at 10:06 AM, David Marchand > wrote: > > Prefer the existing apis rather than direct access the configuration > structure. > > test_hash_multi_add_lookup() currently starts n readers and N writers > using rte_eal_re

[dpdk-dev] [PATCH v2 1/2] test/hash: use existing lcore API

2019-05-22 Thread David Marchand
Prefer the existing apis rather than direct access the configuration structure. test_hash_multi_add_lookup() currently starts n readers and N writers using rte_eal_remote_launch(). It then waits for the N writers to complete with a custom multi_writer_done[] array to synchronise over. Jump on the