[dpdk-dev] [PATCH v2 1/3] mempool: add stack (lifo) mempool handler

2016-06-29 Thread Olivier MATZ
Hi Dave, On 06/20/2016 02:59 PM, Hunt, David wrote: > Hi Olivier, > > On 20/6/2016 9:17 AM, Olivier Matz wrote: >> Hi David, >> >> On 06/17/2016 04:18 PM, Hunt, David wrote: After reading it, I realize that it's nearly exactly the same code than in "app/test: test external mempool handle

[dpdk-dev] [PATCH v2 1/3] mempool: add stack (lifo) mempool handler

2016-06-20 Thread Hunt, David
Hi Olivier, On 20/6/2016 9:17 AM, Olivier Matz wrote: > Hi David, > > On 06/17/2016 04:18 PM, Hunt, David wrote: >>> After reading it, I realize that it's nearly exactly the same code than >>> in "app/test: test external mempool handler". >>> http://patchwork.dpdk.org/dev/patchwork/patch/12896/ >>

[dpdk-dev] [PATCH v2 1/3] mempool: add stack (lifo) mempool handler

2016-06-20 Thread Olivier Matz
Hi David, On 06/17/2016 04:18 PM, Hunt, David wrote: >> After reading it, I realize that it's nearly exactly the same code than >> in "app/test: test external mempool handler". >> http://patchwork.dpdk.org/dev/patchwork/patch/12896/ >> >> We should drop one of them. If this stack handler is really

[dpdk-dev] [PATCH v2 1/3] mempool: add stack (lifo) mempool handler

2016-06-17 Thread Hunt, David
Hi Olivier, On 23/5/2016 1:55 PM, Olivier Matz wrote: > Hi David, > > Please find some comments below. > > On 05/19/2016 04:48 PM, David Hunt wrote: >> [...] >> +++ b/lib/librte_mempool/rte_mempool_stack.c >> @@ -0,0 +1,145 @@ >> +/*- >> + * BSD LICENSE >> + * >> + * Copyright(c) 2010-2014 Int

[dpdk-dev] [PATCH v2 1/3] mempool: add stack (lifo) mempool handler

2016-06-15 Thread Hunt, David
Hi Olivier, On 23/5/2016 1:55 PM, Olivier Matz wrote: > Hi David, > > Please find some comments below. > > On 05/19/2016 04:48 PM, David Hunt wrote: >> This is a mempool handler that is useful for pipelining apps, where >> the mempool cache doesn't really work - example, where we have one >> core

[dpdk-dev] [PATCH v2 1/3] mempool: add stack (lifo) mempool handler

2016-05-23 Thread Olivier Matz
Hi David, Please find some comments below. On 05/19/2016 04:48 PM, David Hunt wrote: > This is a mempool handler that is useful for pipelining apps, where > the mempool cache doesn't really work - example, where we have one > core doing rx (and alloc), and another core doing Tx (and return). In >

[dpdk-dev] [PATCH v2 1/3] mempool: add stack (lifo) mempool handler

2016-05-19 Thread David Hunt
This is a mempool handler that is useful for pipelining apps, where the mempool cache doesn't really work - example, where we have one core doing rx (and alloc), and another core doing Tx (and return). In such a case, the mempool ring simply cycles through all the mbufs, resulting in a LLC miss on