Re: [dpdk-dev] [PATCH v2 1/4] power: changed unsigned to unsigned int

2017-12-11 Thread Hunt, David
Hi Marko, On 28/11/2017 1:22 PM, Marko Kovacevic wrote: --snip-- int -guest_channel_host_connect(const char *path, unsigned lcore_id) +guest_channel_host_connect(const char *path, unsigned int lcore_id) --snip-- I'd suggest adding the following into the commit message. It would help e

Re: [dpdk-dev] [PATCH v2 1/4] power: changed unsigned to unsigned int

2017-11-29 Thread Marko Kovacevic
As i saw that many other variables were changed from unsigned to unsigned int and since i was cleaning up the code i thought it would be beneficial to change it now not to cause checkpatch problems or other problems down the line. Marko On 28/11/2017 14:16, Bruce Richardson wrote: On Tue, Nov

Re: [dpdk-dev] [PATCH v2 1/4] power: changed unsigned to unsigned int

2017-11-28 Thread Bruce Richardson
On Tue, Nov 28, 2017 at 01:22:00PM +, Marko Kovacevic wrote: > Signed-off-by: Marko Kovacevic > --- While I know that checkpatch complains about unsigned vs unsigned int, is there some other reason for making this change wholesale in the code? /Bruce

[dpdk-dev] [PATCH v2 1/4] power: changed unsigned to unsigned int

2017-11-28 Thread Marko Kovacevic
Signed-off-by: Marko Kovacevic --- lib/librte_power/guest_channel.c | 6 +++--- lib/librte_power/guest_channel.h | 6 +++--- lib/librte_power/rte_power.c | 4 ++-- lib/librte_power/rte_power.h | 12 ++-- lib/librte_power/rte_power_acpi_cpufre