Re: [dpdk-dev] [PATCH v2 1/7] ethdev: introduce sample action for rte flow

2020-07-06 Thread Jerin Jacob
On Sun, Jul 5, 2020 at 10:22 AM Matan Azrad wrote: > > > > From: Jerin Jacob: > > On Sun, Jul 5, 2020 at 12:56 AM Matan Azrad wrote: > > > > > > Hi all > > > > > > From: Jerin Jacob: > > > > On Fri, Jul 3, 2020 at 8:57 PM Thomas Monjalon > > > > wrote: > > > > > > > > > > 03/07/2020 17:08, Jerin

Re: [dpdk-dev] [PATCH v2 1/7] ethdev: introduce sample action for rte flow

2020-07-05 Thread Jiawei(Jonny) Wang
; f...@redhat.com > Subject: RE: [dpdk-dev] [PATCH v2 1/7] ethdev: introduce sample action for > rte flow > > Hi Andrew, > > I replied to some of your comments. > Best, > Ori > > -Original Message- > > From: dev On Behalf Of Andrew Rybchenko > > Se

Re: [dpdk-dev] [PATCH v2 1/7] ethdev: introduce sample action for rte flow

2020-07-05 Thread Ajit Khaparde
On Sun, Jul 5, 2020 at 1:55 AM Thomas Monjalon wrote: > 04/07/2020 16:44, Ajit Khaparde: > > On Thu, Jul 2, 2020 at 11:40 PM Jerin Jacob > wrote: > > > When adding overlapping API(rte_eth_mirror_rule_set()) in the same > > > library(ethdev). > > > Please depreciate the old API. > > > We should n

Re: [dpdk-dev] [PATCH v2 1/7] ethdev: introduce sample action for rte flow

2020-07-05 Thread Ajit Khaparde
On Sun, Jul 5, 2020 at 3:19 AM Ori Kam wrote: > Hi Andrew, > > I replied to some of your comments. > Best, > Ori > > -Original Message- > > From: dev On Behalf Of Andrew Rybchenko > > Sent: Saturday, July 4, 2020 4:05 PM > > Subject: Re: [dpd

Re: [dpdk-dev] [PATCH v2 1/7] ethdev: introduce sample action for rte flow

2020-07-05 Thread Ori Kam
Hi Andrew, I replied to some of your comments. Best, Ori > -Original Message- > From: dev On Behalf Of Andrew Rybchenko > Sent: Saturday, July 4, 2020 4:05 PM > Subject: Re: [dpdk-dev] [PATCH v2 1/7] ethdev: introduce sample action for rte > flow > > On 7/2/20

Re: [dpdk-dev] [PATCH v2 1/7] ethdev: introduce sample action for rte flow

2020-07-05 Thread Thomas Monjalon
04/07/2020 16:44, Ajit Khaparde: > On Thu, Jul 2, 2020 at 11:40 PM Jerin Jacob wrote: > > When adding overlapping API(rte_eth_mirror_rule_set()) in the same > > library(ethdev). > > Please depreciate the old API. > > We should not have two separate paths for the same function in the > > same ethde

Re: [dpdk-dev] [PATCH v2 1/7] ethdev: introduce sample action for rte flow

2020-07-04 Thread Matan Azrad
From: Jerin Jacob: > On Sun, Jul 5, 2020 at 12:56 AM Matan Azrad wrote: > > > > Hi all > > > > From: Jerin Jacob: > > > On Fri, Jul 3, 2020 at 8:57 PM Thomas Monjalon > > > wrote: > > > > > > > > 03/07/2020 17:08, Jerin Jacob: > > > > > On Fri, Jul 3, 2020 at 8:25 PM Matan Azrad > > > wrote: >

Re: [dpdk-dev] [PATCH v2 1/7] ethdev: introduce sample action for rte flow

2020-07-04 Thread Jerin Jacob
On Sun, Jul 5, 2020 at 12:56 AM Matan Azrad wrote: > > Hi all > > From: Jerin Jacob: > > On Fri, Jul 3, 2020 at 8:57 PM Thomas Monjalon > > wrote: > > > > > > 03/07/2020 17:08, Jerin Jacob: > > > > On Fri, Jul 3, 2020 at 8:25 PM Matan Azrad > > wrote: > > > > > From: Jerin Jacob: > > > > > > Whe

Re: [dpdk-dev] [PATCH v2 1/7] ethdev: introduce sample action for rte flow

2020-07-04 Thread Matan Azrad
Hi all From: Jerin Jacob: > On Fri, Jul 3, 2020 at 8:57 PM Thomas Monjalon > wrote: > > > > 03/07/2020 17:08, Jerin Jacob: > > > On Fri, Jul 3, 2020 at 8:25 PM Matan Azrad > wrote: > > > > From: Jerin Jacob: > > > > > When adding overlapping API(rte_eth_mirror_rule_set()) in the > > > > > same l

Re: [dpdk-dev] [PATCH v2 1/7] ethdev: introduce sample action for rte flow

2020-07-04 Thread Ajit Khaparde
On Thu, Jul 2, 2020 at 11:40 PM Jerin Jacob wrote: > On Fri, Jul 3, 2020 at 12:13 AM Jiawei Wang wrote: > > > > When using full offload, all traffic will be handled by the HW, and > > directed to the requested vf or wire, the control application loses > > visibility on the traffic. > > So there'

Re: [dpdk-dev] [PATCH v2 1/7] ethdev: introduce sample action for rte flow

2020-07-04 Thread Ajit Khaparde
On Fri, Jul 3, 2020 at 8:27 AM Thomas Monjalon wrote: > 03/07/2020 17:08, Jerin Jacob: > > On Fri, Jul 3, 2020 at 8:25 PM Matan Azrad wrote: > > > From: Jerin Jacob: > > > > When adding overlapping API(rte_eth_mirror_rule_set()) in the same > > > > library(ethdev). > > > > Please depreciate the

Re: [dpdk-dev] [PATCH v2 1/7] ethdev: introduce sample action for rte flow

2020-07-04 Thread Andrew Rybchenko
On 7/2/20 9:43 PM, Jiawei Wang wrote: > When using full offload, all traffic will be handled by the HW, and > directed to the requested vf or wire, the control application loses vf->VF > visibility on the traffic. > So there's a need for an action that will enable the control application > some v

Re: [dpdk-dev] [PATCH v2 1/7] ethdev: introduce sample action for rte flow

2020-07-03 Thread Jerin Jacob
On Fri, Jul 3, 2020 at 8:57 PM Thomas Monjalon wrote: > > 03/07/2020 17:08, Jerin Jacob: > > On Fri, Jul 3, 2020 at 8:25 PM Matan Azrad wrote: > > > From: Jerin Jacob: > > > > When adding overlapping API(rte_eth_mirror_rule_set()) in the same > > > > library(ethdev). > > > > Please depreciate the

Re: [dpdk-dev] [PATCH v2 1/7] ethdev: introduce sample action for rte flow

2020-07-03 Thread Matan Azrad
From: Jerin Jacob > On Fri, Jul 3, 2020 at 8:25 PM Matan Azrad wrote: > > > > > > Hi Jerin > > Hi Matan, > > > > > From: Jerin Jacob: > > > On Fri, Jul 3, 2020 at 12:13 AM Jiawei Wang > wrote: > > > > > > > > When using full offload, all traffic will be handled by the HW, > > > > and directed

Re: [dpdk-dev] [PATCH v2 1/7] ethdev: introduce sample action for rte flow

2020-07-03 Thread Thomas Monjalon
03/07/2020 17:08, Jerin Jacob: > On Fri, Jul 3, 2020 at 8:25 PM Matan Azrad wrote: > > From: Jerin Jacob: > > > When adding overlapping API(rte_eth_mirror_rule_set()) in the same > > > library(ethdev). > > > Please depreciate the old API. > > > We should not have two separate paths for the same fu

Re: [dpdk-dev] [PATCH v2 1/7] ethdev: introduce sample action for rte flow

2020-07-03 Thread Jerin Jacob
On Fri, Jul 3, 2020 at 8:25 PM Matan Azrad wrote: > > > Hi Jerin Hi Matan, > > From: Jerin Jacob: > > On Fri, Jul 3, 2020 at 12:13 AM Jiawei Wang wrote: > > > > > > When using full offload, all traffic will be handled by the HW, and > > > directed to the requested vf or wire, the control applic

Re: [dpdk-dev] [PATCH v2 1/7] ethdev: introduce sample action for rte flow

2020-07-03 Thread Matan Azrad
Hi Jerin From: Jerin Jacob: > On Fri, Jul 3, 2020 at 12:13 AM Jiawei Wang wrote: > > > > When using full offload, all traffic will be handled by the HW, and > > directed to the requested vf or wire, the control application loses > > visibility on the traffic. > > So there's a need for an action

Re: [dpdk-dev] [PATCH v2 1/7] ethdev: introduce sample action for rte flow

2020-07-02 Thread Jerin Jacob
On Fri, Jul 3, 2020 at 12:13 AM Jiawei Wang wrote: > > When using full offload, all traffic will be handled by the HW, and > directed to the requested vf or wire, the control application loses > visibility on the traffic. > So there's a need for an action that will enable the control application >

[dpdk-dev] [PATCH v2 1/7] ethdev: introduce sample action for rte flow

2020-07-02 Thread Jiawei Wang
When using full offload, all traffic will be handled by the HW, and directed to the requested vf or wire, the control application loses visibility on the traffic. So there's a need for an action that will enable the control application some visibility. The solution is introduced a new action that