Re: [dpdk-dev] [PATCH v2 1/7] test/hash: fix bucket size in hash perf test

2018-09-28 Thread Wang, Yipeng1
>-Original Message- >From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@arm.com] >> several times */ -#define BUCKET_SIZE 4 >> +#define BUCKET_SIZE 8 >May be we should add a comment to warn that it should be same as ' >RTE_HASH_BUCKET_ENTRIES'? > [Wang, Yipeng] Done in V4, Thanks for

Re: [dpdk-dev] [PATCH v2 1/7] test/hash: fix bucket size in hash perf test

2018-09-26 Thread Honnappa Nagarahalli
> -Original Message- > From: Yipeng Wang > Sent: Friday, September 21, 2018 12:17 PM > To: bruce.richard...@intel.com > Cc: dev@dpdk.org; yipeng1.w...@intel.com; mic...@digirati.com.br; > Honnappa Nagarahalli > Subject: [PATCH v2 1/7] test/hash: fix bucket size in hash perf test > > T

Re: [dpdk-dev] [PATCH v2 1/7] test/hash: fix bucket size in hash perf test

2018-09-26 Thread Wang, Yipeng1
Hi Bruce, In the test, the bucket size and number of buckets are used to map to the underneath rte_hash structure. They are used to test performance of two scenarios: keys in primary buckets only and keys in both primary and secondary buckets. Although there is no functional issue with bucket siz

Re: [dpdk-dev] [PATCH v2 1/7] test/hash: fix bucket size in hash perf test

2018-09-26 Thread Bruce Richardson
On Fri, Sep 21, 2018 at 10:17:29AM -0700, Yipeng Wang wrote: > The bucket size was changed from 4 to 8 but the corresponding > perf test was not changed accordingly. > Can you perhaps give a little detail on what actual problems this caused. Did it just mean that we used up too much memory in the

[dpdk-dev] [PATCH v2 1/7] test/hash: fix bucket size in hash perf test

2018-09-21 Thread Yipeng Wang
The bucket size was changed from 4 to 8 but the corresponding perf test was not changed accordingly. Fixes: 58017c98ed53 ("hash: add vectorized comparison") Cc: sta...@dpdk.org Signed-off-by: Yipeng Wang --- test/test/test_hash_perf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff