Re: [dpdk-dev] [PATCH v2 11/15] net/avp: packet receive functions

2017-03-01 Thread Legacy, Allain
> -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > > In checkpatch source there is a regex to identify logging functions and > special > exceptions for long lines etc. But the logging functions are for kernel > (printk > etc), not DPDK logging functions

Re: [dpdk-dev] [PATCH v2 11/15] net/avp: packet receive functions

2017-03-01 Thread Stephen Hemminger
On Wed, 01 Mar 2017 15:14:57 +0100 Thomas Monjalon wrote: > 2017-03-01 13:23, Legacy, Allain: > > > -Original Message- > > > From: Bruce Richardson [mailto:bruce.richard...@intel.com] > > > In my experience, checkpatch ignores long lines that are due to error > > > messages. Perhaps you n

Re: [dpdk-dev] [PATCH v2 11/15] net/avp: packet receive functions

2017-03-01 Thread Legacy, Allain
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] > > WARNING:LONG_LINE_STRING: line over 80 characters > > #120: FILE: drivers/net/avp/avp_ethdev.c:236: > > + PMD_DRV_LOG(ERR, "Timeout while waiting for a > response for %u\n", > > > > There

Re: [dpdk-dev] [PATCH v2 11/15] net/avp: packet receive functions

2017-03-01 Thread Thomas Monjalon
2017-03-01 13:23, Legacy, Allain: > > -Original Message- > > From: Bruce Richardson [mailto:bruce.richard...@intel.com] > > In my experience, checkpatch ignores long lines that are due to error > > messages. Perhaps you need to put the error message on a separate line, > > if other things b

Re: [dpdk-dev] [PATCH v2 11/15] net/avp: packet receive functions

2017-03-01 Thread Legacy, Allain
> -Original Message- > From: Bruce Richardson [mailto:bruce.richard...@intel.com] > In my experience, checkpatch ignores long lines that are due to error > messages. Perhaps you need to put the error message on a separate line, > if other things before the message are of significant size. I

Re: [dpdk-dev] [PATCH v2 11/15] net/avp: packet receive functions

2017-02-28 Thread Bruce Richardson
On Mon, Feb 27, 2017 at 05:06:24PM +, Legacy, Allain wrote: > > > -Original Message- > > From: Stephen Hemminger [mailto:step...@networkplumber.org] > > On Sun, 26 Feb 2017 14:08:59 -0500 > > Allain Legacy wrote: > > > > Try not to break error messages onto two lines, it makes it har

Re: [dpdk-dev] [PATCH v2 11/15] net/avp: packet receive functions

2017-02-27 Thread Legacy, Allain
> -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > On Sun, 26 Feb 2017 14:08:59 -0500 > Allain Legacy wrote: > > Try not to break error messages onto two lines, it makes it harder when a > user is trying to find the location of the error message with sea

Re: [dpdk-dev] [PATCH v2 11/15] net/avp: packet receive functions

2017-02-27 Thread Stephen Hemminger
On Sun, 26 Feb 2017 14:08:59 -0500 Allain Legacy wrote: > + if (eth_dev->data->scattered_rx) { > + PMD_DRV_LOG(NOTICE, > + "AVP device configured " > + "for chained mbufs\n"); Try not to break error m

[dpdk-dev] [PATCH v2 11/15] net/avp: packet receive functions

2017-02-26 Thread Allain Legacy
Adds function required for receiving packets from the host application via AVP device queues. Both the simple and scattered functions are supported. Signed-off-by: Allain Legacy Signed-off-by: Matt Peters --- drivers/net/avp/Makefile | 1 + drivers/net/avp/avp_ethdev.c | 468