Re: [dpdk-dev] [PATCH v2 2/2] build: support building ABI versioned files twice

2019-10-07 Thread Bruce Richardson
On Tue, Oct 01, 2019 at 05:53:05PM +0100, Bruce Richardson wrote: > On Tue, Oct 01, 2019 at 03:23:47PM +0200, Andrzej Ostruszka wrote: > > Thanks Bruce for the patch. I like the idea of splitting versioning out > > of rte_compat.h, but I have some comments. > > > > On 9/27/19 10:59 PM, Bruce Rich

Re: [dpdk-dev] [PATCH v2 2/2] build: support building ABI versioned files twice

2019-10-01 Thread Bruce Richardson
On Tue, Oct 01, 2019 at 03:23:47PM +0200, Andrzej Ostruszka wrote: > Thanks Bruce for the patch. I like the idea of splitting versioning out > of rte_compat.h, but I have some comments. > > On 9/27/19 10:59 PM, Bruce Richardson wrote: > [...] > > --- a/config/common_base > > +++ b/config/common_b

Re: [dpdk-dev] [PATCH v2 2/2] build: support building ABI versioned files twice

2019-10-01 Thread Andrzej Ostruszka
Thanks Bruce for the patch. I like the idea of splitting versioning out of rte_compat.h, but I have some comments. On 9/27/19 10:59 PM, Bruce Richardson wrote: [...] > --- a/config/common_base > +++ b/config/common_base > @@ -111,6 +111,7 @@ CONFIG_RTE_MAX_VFIO_CONTAINERS=64 > CONFIG_RTE_MALLOC_

[dpdk-dev] [PATCH v2 2/2] build: support building ABI versioned files twice

2019-09-27 Thread Bruce Richardson
Any file with ABI versioned functions needs different macros for shared and static builds, so we need to accomodate that. Rather than building everything twice, we just flag to the build system which libraries need that handling, by setting use_function_versioning in the meson.build files. To ensu