Since we changed the vhost library as a common framework to add other
VIRTIO device type, here we add VIRTIO_ID_SCSI device type to vhost
library to support vhost-scsi target.
Signed-off-by: Changpeng Liu
---
lib/librte_vhost/Makefile | 4 +-
lib/librte_vhost/rte_virtio_dev.h | 1 +
On Wed, Sep 14, 2016 at 04:46:21AM +, Liu, Changpeng wrote:
> > Few more generic comments:
> >
> > - you touched way more code than necessary.
> >
> > - you should split your patches into some small patches: one patch just
> > does one tiny logic. Doing one bunch of stuff in one patch is re
On Thu, Sep 15, 2016 at 08:28:18AM +0800, Changpeng Liu wrote:
> Since we changed the vhost library as a common framework to add other
As I said in my earlier email, I don't see how common it becomes after
your refactoring. __Another__ for example, I just saw a bunch of
duplicated code below that
> -Original Message-
> From: Yuanhan Liu [mailto:yuanhan.liu at linux.intel.com]
> Sent: Wednesday, September 14, 2016 11:29 AM
> To: Liu, Changpeng
> Cc: dev at dpdk.org; Harris, James R
> Subject: Re: [PATCH v2 2/2] vhost: add vhost-scsi support to vhost library
>
> On Thu, Sep 15, 2
4 matches
Mail list logo
