[dpdk-dev] [PATCH v2 2/3] hash: add predictable RSS implementation

2021-04-06 Thread Vladimir Medvedkin
This patch implements predictable RSS functionality. Signed-off-by: Vladimir Medvedkin --- lib/librte_hash/rte_thash.c | 577 ++-- lib/librte_hash/rte_thash.h | 42 lib/librte_hash/version.map | 1 + 3 files changed, 602 insertions(+), 18 deletions

Re: [dpdk-dev] [PATCH v2 2/3] hash: add predictable RSS implementation

2021-04-07 Thread Ananyev, Konstantin
Hi Vladimir, Few comments below, mostly minor. One generic one - doc seems missing. With that in place: Acked-by: Konstantin Ananyev > > This patch implements predictable RSS functionality. > > Signed-off-by: Vladimir Medvedkin > --- > lib/librte_hash/rte_thash.c | 577 > +++

Re: [dpdk-dev] [PATCH v2 2/3] hash: add predictable RSS implementation

2021-04-09 Thread Wang, Yipeng1
> -Original Message- > From: Medvedkin, Vladimir > Sent: Tuesday, April 6, 2021 12:51 PM > To: dev@dpdk.org > Cc: Ananyev, Konstantin ; Chilikin, Andrey > ; Kinsella, Ray ; Wang, > Yipeng1 ; Gobriel, Sameh > ; Richardson, Bruce > > Subject: [PATCH v2 2/3] hash: add predictable RSS impleme

Re: [dpdk-dev] [PATCH v2 2/3] hash: add predictable RSS implementation

2021-04-11 Thread Medvedkin, Vladimir
Hi Konstantin, Thanks for the review, On 07/04/2021 15:53, Ananyev, Konstantin wrote: Hi Vladimir, Few comments below, mostly minor. One generic one - doc seems missing. With that in place: Acked-by: Konstantin Ananyev This patch implements predictable RSS functionality. Signed-off-by: Vl

Re: [dpdk-dev] [PATCH v2 2/3] hash: add predictable RSS implementation

2021-04-11 Thread Medvedkin, Vladimir
On 10/04/2021 03:10, Wang, Yipeng1 wrote: -Original Message- From: Medvedkin, Vladimir Sent: Tuesday, April 6, 2021 12:51 PM To: dev@dpdk.org Cc: Ananyev, Konstantin ; Chilikin, Andrey ; Kinsella, Ray ; Wang, Yipeng1 ; Gobriel, Sameh ; Richardson, Bruce Subject: [PATCH v2 2/3] hash:

Re: [dpdk-dev] [PATCH v2 2/3] hash: add predictable RSS implementation

2021-04-12 Thread Ananyev, Konstantin
> > > > >> +#defineRETA_SZ_MIN2U > >> +#defineRETA_SZ_MAX16U > > > > Should these RETA_SZ defines be in public header? > > So user can know what are allowed values? > > > > I don't think this is necessary, because the user chooses it not > arbitrary, but depending on the NIC. Sure thing, but i

Re: [dpdk-dev] [PATCH v2 2/3] hash: add predictable RSS implementation

2021-04-13 Thread Medvedkin, Vladimir
Hi Konstantin, On 12/04/2021 12:47, Ananyev, Konstantin wrote: +#defineRETA_SZ_MIN2U +#defineRETA_SZ_MAX16U Should these RETA_SZ defines be in public header? So user can know what are allowed values? I don't think this is necessary, because the user chooses it not arbitrary, but dependi