[dpdk-dev] [PATCH v2 2/3] net/mlx5: fix link status behavior

2018-03-12 Thread Nelio Laranjeiro
This behavior is mixed between what should be handled by the application and what is under PMD responsibility. According to DPDK API: - link_update() should only query the link status [1] - link_set_{up,down}() should only set the link to the according status [1] - dev_{start,stop}() should enable

Re: [dpdk-dev] [PATCH v2 2/3] net/mlx5: fix link status behavior

2018-03-13 Thread Yongseok Koh
On Mon, Mar 12, 2018 at 02:43:18PM +0100, Nelio Laranjeiro wrote: > This behavior is mixed between what should be handled by the application > and what is under PMD responsibility. > > According to DPDK API: > - link_update() should only query the link status [1] > - link_set_{up,down}() should on

Re: [dpdk-dev] [PATCH v2 2/3] net/mlx5: fix link status behavior

2018-03-14 Thread Adrien Mazarguil
On Tue, Mar 13, 2018 at 02:54:44PM -0700, Yongseok Koh wrote: > On Mon, Mar 12, 2018 at 02:43:18PM +0100, Nelio Laranjeiro wrote: > > This behavior is mixed between what should be handled by the application > > and what is under PMD responsibility. > > > > According to DPDK API: > > - link_update(

Re: [dpdk-dev] [PATCH v2 2/3] net/mlx5: fix link status behavior

2018-03-14 Thread Nélio Laranjeiro
On Tue, Mar 13, 2018 at 02:54:44PM -0700, Yongseok Koh wrote: > On Mon, Mar 12, 2018 at 02:43:18PM +0100, Nelio Laranjeiro wrote: > > This behavior is mixed between what should be handled by the application > > and what is under PMD responsibility. > > > > According to DPDK API: > > - link_update(

Re: [dpdk-dev] [PATCH v2 2/3] net/mlx5: fix link status behavior

2018-03-14 Thread Yongseok Koh
On Wed, Mar 14, 2018 at 01:18:56PM +0100, Adrien Mazarguil wrote: > On Tue, Mar 13, 2018 at 02:54:44PM -0700, Yongseok Koh wrote: > > On Mon, Mar 12, 2018 at 02:43:18PM +0100, Nelio Laranjeiro wrote: > > > This behavior is mixed between what should be handled by the application > > > and what is un

Re: [dpdk-dev] [PATCH v2 2/3] net/mlx5: fix link status behavior

2018-03-14 Thread Adrien Mazarguil
On Wed, Mar 14, 2018 at 10:40:59AM -0700, Yongseok Koh wrote: > On Wed, Mar 14, 2018 at 01:18:56PM +0100, Adrien Mazarguil wrote: > > On Tue, Mar 13, 2018 at 02:54:44PM -0700, Yongseok Koh wrote: > > > On Mon, Mar 12, 2018 at 02:43:18PM +0100, Nelio Laranjeiro wrote: > > > > This behavior is mixed

Re: [dpdk-dev] [PATCH v2 2/3] net/mlx5: fix link status behavior

2018-03-15 Thread Yongseok Koh
> On Mar 12, 2018, at 6:43 AM, Nelio Laranjeiro > wrote: > > This behavior is mixed between what should be handled by the application > and what is under PMD responsibility. > > According to DPDK API: > - link_update() should only query the link status [1] > - link_set_{up,down}() should only