Re: [dpdk-dev] [PATCH v2 2/3] net/vmxnet3: fix vmxnet3 dev_uninit() hot-unplug

2018-10-31 Thread Louis Luo
Hey I'm taking paternity leave now so late on response. The v1 was different from what Thomas asked for and (hw->adapter_stopped == 0) was ignored (see cited below). So we felt uncomfortable about that as there is no guarantee that the device has been closed before calling uninit. Now that you

Re: [dpdk-dev] [PATCH v2 2/3] net/vmxnet3: fix vmxnet3 dev_uninit() hot-unplug

2018-10-31 Thread Thomas Monjalon
31/10/2018 18:46, Luca Boccassi: > Sorry, been otherwise busy - I can do what you and Chas have asked, but > the problem is that v1 already did that and the VMWare maintainers > asked to change it back. So can I assume that the v1 way is the way to > go? I am expecting an answer from the vmxnet3 m

Re: [dpdk-dev] [PATCH v2 2/3] net/vmxnet3: fix vmxnet3 dev_uninit() hot-unplug

2018-10-31 Thread Luca Boccassi
Sorry, been otherwise busy - I can do what you and Chas have asked, but the problem is that v1 already did that and the VMWare maintainers asked to change it back. So can I assume that the v1 way is the way to go? On Wed, 2018-10-31 at 18:27 +0100, Thomas Monjalon wrote: > Any update or question f

Re: [dpdk-dev] [PATCH v2 2/3] net/vmxnet3: fix vmxnet3 dev_uninit() hot-unplug

2018-10-31 Thread Thomas Monjalon
Any update or question for this patch? If no update, it will miss 18.11. 27/10/2018 17:09, Thomas Monjalon: > 19/09/2018 17:47, Chas Williams: > > On Wed, Sep 19, 2018 at 8:58 AM Luca Boccassi wrote: > > > > > > The vmxnet3 driver can't call back into dev_close(), and possibly > > > dev_stop(),

Re: [dpdk-dev] [PATCH v2 2/3] net/vmxnet3: fix vmxnet3 dev_uninit() hot-unplug

2018-10-27 Thread Thomas Monjalon
19/09/2018 17:47, Chas Williams: > On Wed, Sep 19, 2018 at 8:58 AM Luca Boccassi wrote: > > > > The vmxnet3 driver can't call back into dev_close(), and possibly > > dev_stop(), in dev_uninit(). When dev_uninit() is called, anything > > that those routines would want to clean up has already been

Re: [dpdk-dev] [PATCH v2 2/3] net/vmxnet3: fix vmxnet3 dev_uninit() hot-unplug

2018-09-27 Thread Luca Boccassi
On Wed, 2018-09-19 at 13:57 +0100, Luca Boccassi wrote: > The vmxnet3 driver can't call back into dev_close(), and possibly > dev_stop(), in dev_uninit().  When dev_uninit() is called, anything > that those routines would want to clean up has already been released. > Further, for complete cleanup,

Re: [dpdk-dev] [PATCH v2 2/3] net/vmxnet3: fix vmxnet3 dev_uninit() hot-unplug

2018-09-19 Thread Luca Boccassi
On Wed, 2018-09-19 at 11:47 -0400, Chas Williams wrote: > On Wed, Sep 19, 2018 at 8:58 AM Luca Boccassi > wrote: > > > > The vmxnet3 driver can't call back into dev_close(), and possibly > > dev_stop(), in dev_uninit().  When dev_uninit() is called, anything > > that those routines would want to

Re: [dpdk-dev] [PATCH v2 2/3] net/vmxnet3: fix vmxnet3 dev_uninit() hot-unplug

2018-09-19 Thread Chas Williams
On Wed, Sep 19, 2018 at 8:58 AM Luca Boccassi wrote: > > The vmxnet3 driver can't call back into dev_close(), and possibly > dev_stop(), in dev_uninit(). When dev_uninit() is called, anything > that those routines would want to clean up has already been released. > Further, for complete cleanup,

[dpdk-dev] [PATCH v2 2/3] net/vmxnet3: fix vmxnet3 dev_uninit() hot-unplug

2018-09-19 Thread Luca Boccassi
The vmxnet3 driver can't call back into dev_close(), and possibly dev_stop(), in dev_uninit(). When dev_uninit() is called, anything that those routines would want to clean up has already been released. Further, for complete cleanup, it is necessary to release any of the queue resources during dev