[dpdk-dev] [PATCH v2 2/7] pci: build on Windows

2020-04-28 Thread talshn
From: Tal Shnaiderman Changing all of PCIs Unix memory mapping to the new memory allocation API wrapper. Added off_t in Windows header file as a supported type since it is needed by PCI. Signed-off-by: Tal Shnaiderman --- lib/librte_eal/windows/include/rte_os.h | 1 + lib/librte_pci/rte_pci.

Re: [dpdk-dev] [PATCH v2 2/7] pci: build on Windows

2020-04-28 Thread Dmitry Kozlyuk
This patch misses two things: 1. Documentation on pci_map_resource() mentions MAP_FAILED, while rte_mem_map() returns NULL on failure. 2. Code in drivers/bus/pci/linux passes MAP_FIXED to pci_map_resource(), which should be changed to corresponding RTE_MAP_FORCE_ADDRESS flag (it is renam