Re: [dpdk-dev] [PATCH v2 3/5] vhost: do not inline unlikely fragmented buffers code

2019-05-24 Thread Maxime Coquelin
On 5/20/19 7:51 AM, Tiwei Bie wrote: On Fri, May 17, 2019 at 05:06:11PM +0200, Maxime Coquelin wrote: [...] +static void +copy_vnet_hdr_from_desc(struct virtio_net_hdr *hdr, + struct buf_vector *buf_vec) +{ + uint64_t len; + uint64_t remain = sizeof(struct virtio_

Re: [dpdk-dev] [PATCH v2 3/5] vhost: do not inline unlikely fragmented buffers code

2019-05-19 Thread Tiwei Bie
On Fri, May 17, 2019 at 05:06:11PM +0200, Maxime Coquelin wrote: [...] > > +static void > +copy_vnet_hdr_from_desc(struct virtio_net_hdr *hdr, > + struct buf_vector *buf_vec) > +{ > + uint64_t len; > + uint64_t remain = sizeof(struct virtio_net_hdr); > + uint64_t src; > +

[dpdk-dev] [PATCH v2 3/5] vhost: do not inline unlikely fragmented buffers code

2019-05-17 Thread Maxime Coquelin
Handling of fragmented virtio-net header and indirect descriptors tables was implemented to fix CVE-2018-1059. It should never happen with healthy guests and so are already considered as unlikely code path. This patch moves these bits into non-inline dedicated functions to reduce the I-cache press