Re: [dpdk-dev] [PATCH v2 3/7] cryptodev/virtio: core code of crypto devices

2018-03-20 Thread Zhoujian (jay)
Hi Fan, Really thank for your response and testing! > -Original Message- > From: Zhang, Roy Fan [mailto:roy.fan.zh...@intel.com] > Sent: Wednesday, March 21, 2018 12:09 PM > To: Zhoujian (jay) ; dev@dpdk.org > Cc: De Lara Guarch, Pablo ; > tho...@monjalon.net; Gonglei (Arei) ; Zeng, Xin >

Re: [dpdk-dev] [PATCH v2 3/7] cryptodev/virtio: core code of crypto devices

2018-03-20 Thread Zhang, Roy Fan
Hi Jay, Excellent work! The patch, although need some minor rework, has improved the performance. Some comments: 1. you need to set up capabilities for virtio_crypto PMD. As in Qemu vhost crypto proxy backend only AESCBC and SHA1 are supported (in cryptodev_vhost_user_init() definition), I bel

[dpdk-dev] [PATCH v2 3/7] cryptodev/virtio: core code of crypto devices

2018-02-24 Thread Jay Zhou
The idea comes from QAT and virtio-net devices. Signed-off-by: Jay Zhou --- drivers/crypto/virtio/virtio_cryptodev.c | 1544 ++ drivers/crypto/virtio/virtio_cryptodev.h | 66 ++ drivers/crypto/virtio/virtio_rxtx.c | 533 +++ 3 files changed, 2143 inser