Re: [dpdk-dev] [PATCH v2 4/4] regexdev: implement regex rte level functions

2020-04-22 Thread Ori Kam
as Monjalon > > Subject: Re: [dpdk-dev] [PATCH v2 4/4] regexdev: implement regex rte level > functions > > Hi, > > > +int > > +rte_regexdev_configure(uint8_t dev_id, const struct rte_regexdev_config > > +*cfg) { &g

Re: [dpdk-dev] [PATCH v2 4/4] regexdev: implement regex rte level functions

2020-04-21 Thread Guy Kaneti
Hi, > +int > +rte_regexdev_configure(uint8_t dev_id, const struct rte_regexdev_config > +*cfg) { > + struct rte_regexdev *dev; > + struct rte_regexdev_info dev_info; > + int ret; > + > + RTE_REGEXDEV_VALID_DEV_ID_OR_ERR_RET(dev_id, -EINVAL); > + if (cfg == NULL) > +

Re: [dpdk-dev] [PATCH v2 4/4] regexdev: implement regex rte level functions

2020-04-21 Thread Ori Kam
as Monjalon > > Subject: Re: [dpdk-dev] [PATCH v2 4/4] regexdev: implement regex rte level > functions > > Hi, > > > +int > > +rte_regexdev_is_valid_dev(uint16_t dev_id) { > > + if (dev_id >= RTE_MAX_REGEXDEV_DEVS || > > + rte_regex_devices[dev_i

Re: [dpdk-dev] [PATCH v2 4/4] regexdev: implement regex rte level functions

2020-04-21 Thread Guy Kaneti
Hi, > +int > +rte_regexdev_is_valid_dev(uint16_t dev_id) { > + if (dev_id >= RTE_MAX_REGEXDEV_DEVS || > + rte_regex_devices[dev_id].state != RTE_REGEXDEV_READY) > + return 0; > + return 1; > +} When is the state changed to RTE_REGEXDEV_READY? Should the PMD change it a

[dpdk-dev] [PATCH v2 4/4] regexdev: implement regex rte level functions

2020-04-17 Thread Ori Kam
This commit implements all the RegEx public API. Signed-off-by: Ori Kam --- v2: * Changes based on changes in previous patch. * Add check to configuration function. * Replace checks with macros. * Move enqueue and dequeue to inline. --- config/common_base | 1 + lib/librte