Re: [dpdk-dev] [PATCH v2 4/6] net/ngbe: add device init and uninit

On Saturday, March 20, 2021 1:47 AM, Stephen Hemminger wrote: > On Fri, 19 Mar 2021 15:26:26 +0800 > Jiawen Wu wrote: > > > +++ b/drivers/net/ngbe/base/ngbe_osdep.h > > @@ -0,0 +1,172 @@ > > > +#define false 0 > > +#define true1 > > These will conflict with normal

Re: [dpdk-dev] [PATCH v2 4/6] net/ngbe: add device init and uninit

On Fri, 19 Mar 2021 15:26:26 +0800 Jiawen Wu wrote: > +++ b/drivers/net/ngbe/base/ngbe_osdep.h > @@ -0,0 +1,172 @@ > +#define false 0 > +#define true1 These will conflict with normal definitions in Why are you not using that? > +#define min(a, b)RTE_MIN(a, b)

[dpdk-dev] [PATCH v2 4/6] net/ngbe: add device init and uninit

Add basic init and uninit function. Map device IDs and subsystem IDs to single ID for easy operation. Signed-off-by: Jiawen Wu --- drivers/net/ngbe/base/meson.build | 4 +- drivers/net/ngbe/base/ngbe.h | 11 ++ drivers/net/ngbe/base/ngbe_hw.c| 59 ++ drivers/net/ngbe/base/