[dpdk-dev] [PATCH v2 4/7] rte_sched: don't clear statistics when read

2015-03-10 Thread Thomas Monjalon
2015-02-24 21:06, Thomas Monjalon: > 2015-02-24 11:18, Stephen Hemminger: > > On Mon, 23 Feb 2015 23:51:31 + > > Thomas Monjalon wrote: > > > Stephen, this patchset is partially acked and could enter in 2.0.0-rc1. > > > May you send a v3 addressing comments? Or should I break the serie by > >

[dpdk-dev] [PATCH v2 4/7] rte_sched: don't clear statistics when read

2015-02-25 Thread Dumitrescu, Cristian
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Thomas Monjalon > Sent: Tuesday, February 24, 2015 8:07 PM > To: Stephen Hemminger > Cc: dev at dpdk.org; Stephen Hemminger > Subject: Re: [dpdk-dev] [PATCH v2 4/7] rte_sched: don'

[dpdk-dev] [PATCH v2 4/7] rte_sched: don't clear statistics when read

2015-02-24 Thread Thomas Monjalon
2015-02-24 11:18, Stephen Hemminger: > On Mon, 23 Feb 2015 23:51:31 + > Thomas Monjalon wrote: > > > 2015-02-05 07:43, Neil Horman: > > > On Wed, Feb 04, 2015 at 10:13:58PM -0800, Stephen Hemminger wrote: > > > > + > > > > +/** > > > > + * Hierarchical scheduler subport statistics reset > > >

[dpdk-dev] [PATCH v2 4/7] rte_sched: don't clear statistics when read

2015-02-24 Thread Stephen Hemminger
On Mon, 23 Feb 2015 23:51:31 + Thomas Monjalon wrote: > 2015-02-05 07:43, Neil Horman: > > On Wed, Feb 04, 2015 at 10:13:58PM -0800, Stephen Hemminger wrote: > > > + > > > +/** > > > + * Hierarchical scheduler subport statistics reset > > > + * > > > + * @param port > > > + * Handle to port

[dpdk-dev] [PATCH v2 4/7] rte_sched: don't clear statistics when read

2015-02-24 Thread Thomas Monjalon
2015-02-05 07:43, Neil Horman: > On Wed, Feb 04, 2015 at 10:13:58PM -0800, Stephen Hemminger wrote: > > + > > +/** > > + * Hierarchical scheduler subport statistics reset > > + * > > + * @param port > > + * Handle to port scheduler instance > > + * @param subport_id > > + * Subport ID > > + * @

[dpdk-dev] [PATCH v2 4/7] rte_sched: don't clear statistics when read

2015-02-23 Thread Dumitrescu, Cristian
> -Original Message- > From: Stephen Hemminger [mailto:stephen at networkplumber.org] > Sent: Saturday, February 21, 2015 1:53 AM > To: Dumitrescu, Cristian > Cc: Thomas Monjalon; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 4/7] rte_sched: don't clear

[dpdk-dev] [PATCH v2 4/7] rte_sched: don't clear statistics when read

2015-02-20 Thread Thomas Monjalon
2015-02-20 20:23, Dumitrescu, Cristian: > From: Stephen Hemminger [mailto:stephen at networkplumber.org] > > On Fri, 20 Feb 2015 18:32:03 + > > "Dumitrescu, Cristian" wrote: > > > > > Stephen, I suggest adding a new build-time configuration option for the > > > librte_sched library in config/

[dpdk-dev] [PATCH v2 4/7] rte_sched: don't clear statistics when read

2015-02-20 Thread Dumitrescu, Cristian
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Friday, February 20, 2015 9:01 PM > To: Dumitrescu, Cristian > Cc: dev at dpdk.org; Stephen Hemminger > Subject: Re: [dpdk-dev] [PATCH v2 4/7] rte_sched: don't clear

[dpdk-dev] [PATCH v2 4/7] rte_sched: don't clear statistics when read

2015-02-20 Thread Dumitrescu, Cristian
> -Original Message- > From: Stephen Hemminger [mailto:stephen at networkplumber.org] > Sent: Friday, February 20, 2015 7:53 PM > To: Dumitrescu, Cristian > Cc: dev at dpdk.org; Stephen Hemminger > Subject: Re: [dpdk-dev] [PATCH v2 4/7] rte_sched: don't clear

[dpdk-dev] [PATCH v2 4/7] rte_sched: don't clear statistics when read

2015-02-20 Thread Dumitrescu, Cristian
> -Original Message- > From: Stephen Hemminger [mailto:stephen at networkplumber.org] > Sent: Monday, February 9, 2015 10:55 PM > To: Dumitrescu, Cristian > Cc: dev at dpdk.org; Stephen Hemminger > Subject: Re: [dpdk-dev] [PATCH v2 4/7] rte_sched: don't clear

[dpdk-dev] [PATCH v2 4/7] rte_sched: don't clear statistics when read

2015-02-20 Thread Stephen Hemminger
On Fri, 20 Feb 2015 21:28:55 + "Dumitrescu, Cristian" wrote: > Agree. > Stephen, how about a run-time solution (I agree it would be much better, why > did I not consider this in the first place?) of adding a new bool parameter > in struct rte_sched_port_params: clear_stats_on_reset? > Both

[dpdk-dev] [PATCH v2 4/7] rte_sched: don't clear statistics when read

2015-02-20 Thread Stephen Hemminger
On Fri, 20 Feb 2015 18:32:03 + "Dumitrescu, Cristian" wrote: > Stephen, I suggest adding a new build-time configuration option for the > librte_sched library in config/common_* files: > CONFIG_RTE_SCHED_STATS_CLEAR_ON_READ. Build time config options do not work for distributions.

[dpdk-dev] [PATCH v2 4/7] rte_sched: don't clear statistics when read

2015-02-09 Thread Dumitrescu, Cristian
- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Stephen Hemminger Sent: Thursday, February 5, 2015 6:14 AM To: dev at dpdk.org Cc: Stephen Hemminger Subject: [dpdk-dev] [PATCH v2 4/7] rte_sched: don't clear statistics when read From: Stephen Hemminger Make rte_sched statistics API work

[dpdk-dev] [PATCH v2 4/7] rte_sched: don't clear statistics when read

2015-02-09 Thread Neil Horman
ck. Neil > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Stephen Hemminger > Sent: Thursday, February 5, 2015 6:14 AM > To: dev at dpdk.org > Cc: Stephen Hemminger > Subject: [dpdk-dev] [PATCH v2 4/7] rte_sched: don't clear statistics whe

[dpdk-dev] [PATCH v2 4/7] rte_sched: don't clear statistics when read

2015-02-09 Thread Stephen Hemminger
On Mon, 9 Feb 2015 22:48:36 + "Dumitrescu, Cristian" wrote: > Hi Stephen, > > What is the reason not to clear statistics on read? Do you have a use-case / > justification for it? > > (BTW, I see you added the reset functions, but was it also your intention to > remove the memset to 0 from

[dpdk-dev] [PATCH v2 4/7] rte_sched: don't clear statistics when read

2015-02-05 Thread Neil Horman
On Wed, Feb 04, 2015 at 10:13:58PM -0800, Stephen Hemminger wrote: > From: Stephen Hemminger > > Make rte_sched statistics API work like the ethernet statistics API. > Don't auto-clear statistics. > > Signed-off-by: Stephen Hemminger > --- > lib/librte_sched/rte_sched.c | 30 ++

[dpdk-dev] [PATCH v2 4/7] rte_sched: don't clear statistics when read

2015-02-04 Thread Stephen Hemminger
From: Stephen Hemminger Make rte_sched statistics API work like the ethernet statistics API. Don't auto-clear statistics. Signed-off-by: Stephen Hemminger --- lib/librte_sched/rte_sched.c | 30 ++ lib/librte_sched/rte_sched.h | 29 + 2 fi