Re: [dpdk-dev] [PATCH v2 5/5] devtools/test-meson-builds: fix support for FreeBSD

2019-04-17 Thread Bruce Richardson
On Wed, Apr 17, 2019 at 06:17:06PM +0200, Thomas Monjalon wrote: > 09/04/2019 12:55, Bruce Richardson: > > --- a/devtools/test-meson-builds.sh > > +++ b/devtools/test-meson-builds.sh > > -set -o pipefail > > +# this option gives an error on BSD > > +if [ "`uname`" = "Linux" ] ; then > > + set -o

Re: [dpdk-dev] [PATCH v2 5/5] devtools/test-meson-builds: fix support for FreeBSD

2019-04-17 Thread Thomas Monjalon
09/04/2019 12:55, Bruce Richardson: > --- a/devtools/test-meson-builds.sh > +++ b/devtools/test-meson-builds.sh > -set -o pipefail > +# this option gives an error on BSD > +if [ "`uname`" = "Linux" ] ; then > + set -o pipefail > +fi I think this is a bash option. We may require bash at the top

[dpdk-dev] [PATCH v2 5/5] devtools/test-meson-builds: fix support for FreeBSD

2019-04-09 Thread Bruce Richardson
The pipefile option does not seem to exist on FreeBSD, giving an error when running the script. Fixes: 5d9176673008 ("devtools: fix meson build test to exit on failure") Signed-off-by: Bruce Richardson Reviewed-by: David Marchand Acked-by: Luca Boccassi --- V2: change "==" to "=" in compariso