Re: [dpdk-dev] [PATCH v2 5/5] vhost: message handling implemented as a callback array

2018-09-10 Thread Tiwei Bie
On Mon, Sep 10, 2018 at 06:43:17PM +0200, Maxime Coquelin wrote: > Hi Ilya, > > On 09/10/2018 06:09 PM, Ilya Maximets wrote: > > Hi Maxime, > > Thanks for pointing to this patch set. I missed it somehow. > > > > This patch could not replace mine [1], because it does not improve > > the message ha

Re: [dpdk-dev] [PATCH v2 5/5] vhost: message handling implemented as a callback array

2018-09-10 Thread Maxime Coquelin
Hi Ilya, On 09/10/2018 06:09 PM, Ilya Maximets wrote: Hi Maxime, Thanks for pointing to this patch set. I missed it somehow. This patch could not replace mine [1], because it does not improve the message handling from the error handling point of view. But it completely changes the code, so we n

Re: [dpdk-dev] [PATCH v2 5/5] vhost: message handling implemented as a callback array

2018-09-10 Thread Ilya Maximets
Hi Maxime, Thanks for pointing to this patch set. I missed it somehow. This patch could not replace mine [1], because it does not improve the message handling from the error handling point of view. But it completely changes the code, so we need to negotiate the order in which they will be applied

Re: [dpdk-dev] [PATCH v2 5/5] vhost: message handling implemented as a callback array

2018-09-10 Thread Maxime Coquelin
On 07/19/2018 09:13 PM, Nikolay Nikolaev wrote: Introduce vhost_message_handlers, which maps the message request type to the message handler. Then replace the switch construct with a map and call. Signed-off-by: Nikolay Nikolaev --- lib/librte_vhost/vhost_user.c | 143 +++-

[dpdk-dev] [PATCH v2 5/5] vhost: message handling implemented as a callback array

2018-07-19 Thread Nikolay Nikolaev
Introduce vhost_message_handlers, which maps the message request type to the message handler. Then replace the switch construct with a map and call. Signed-off-by: Nikolay Nikolaev --- lib/librte_vhost/vhost_user.c | 143 +++-- 1 file changed, 54 insertions(+