[dpdk-dev] [PATCH v2 5/6] rte_sched: allow reading statistics without clearing

2015-03-16 Thread Dumitrescu, Cristian
> -Original Message- > From: Stephen Hemminger [mailto:stephen at networkplumber.org] > Sent: Monday, March 16, 2015 8:11 PM > To: Dumitrescu, Cristian > Cc: dev at dpdk.org; Stephen Hemminger > Subject: Re: [PATCH v2 5/6] rte_sched: allow reading statistics without > clearing > > On Mon

[dpdk-dev] [PATCH v2 5/6] rte_sched: allow reading statistics without clearing

2015-03-16 Thread Dumitrescu, Cristian
> -Original Message- > From: Stephen Hemminger [mailto:stephen at networkplumber.org] > Sent: Tuesday, March 10, 2015 4:14 PM > To: Dumitrescu, Cristian > Cc: dev at dpdk.org; Stephen Hemminger; Stephen Hemminger > Subject: [PATCH v2 5/6] rte_sched: allow reading statistics without cleari

[dpdk-dev] [PATCH v2 5/6] rte_sched: allow reading statistics without clearing

2015-03-16 Thread Dumitrescu, Cristian
> -Original Message- > From: Stephen Hemminger [mailto:stephen at networkplumber.org] > Sent: Thursday, March 12, 2015 11:06 PM > To: Dumitrescu, Cristian > Cc: dev at dpdk.org; Stephen Hemminger > Subject: Re: [PATCH v2 5/6] rte_sched: allow reading statistics without > clearing > > On

[dpdk-dev] [PATCH v2 5/6] rte_sched: allow reading statistics without clearing

2015-03-16 Thread Stephen Hemminger
On Mon, 16 Mar 2015 20:21:39 + "Dumitrescu, Cristian" wrote: > When stats read is decoupled from stats clear, the exchange operation cannot > fix this. > > To your point: when stats are cleared on read, would it make sense to use the > exchange operation? In my opinion, it does not make se

[dpdk-dev] [PATCH v2 5/6] rte_sched: allow reading statistics without clearing

2015-03-16 Thread Stephen Hemminger
On Mon, 16 Mar 2015 19:58:51 + "Dumitrescu, Cristian" wrote: > > > > -Original Message- > > From: Stephen Hemminger [mailto:stephen at networkplumber.org] > > Sent: Thursday, March 12, 2015 11:06 PM > > To: Dumitrescu, Cristian > > Cc: dev at dpdk.org; Stephen Hemminger > > Subject:

[dpdk-dev] [PATCH v2 5/6] rte_sched: allow reading statistics without clearing

2015-03-12 Thread Dumitrescu, Cristian
> -Original Message- > From: Stephen Hemminger [mailto:stephen at networkplumber.org] > Sent: Tuesday, March 10, 2015 4:14 PM > To: Dumitrescu, Cristian > Cc: dev at dpdk.org; Stephen Hemminger; Stephen Hemminger > Subject: [PATCH v2 5/6] rte_sched: allow reading statistics without cleari

[dpdk-dev] [PATCH v2 5/6] rte_sched: allow reading statistics without clearing

2015-03-12 Thread Stephen Hemminger
On Thu, 12 Mar 2015 19:28:11 + "Dumitrescu, Cristian" wrote: > Hi Stephen, > > Thank you for adding flexibility over clearing the stats or not. > > I have one concern though: why change the stats read API to add a clear > parameter rather than keep prototype for the stats functions unchang

[dpdk-dev] [PATCH v2 5/6] rte_sched: allow reading statistics without clearing

2015-03-10 Thread Stephen Hemminger
From: Stephen Hemminger The rte_sched statistics API should allow reading statistics without clearing. Make auto-clear optional. Signed-off-by: Stephen Hemminger --- v2 -- change to flag for clear from separate read/clear app/test/test_sched.c| 4 ++-- examples/qos_sched/stats.c |