Re: [dpdk-dev] [PATCH v21 1/7] dmadev: introduce DMA device library public APIs

2021-09-15 Thread fengchengwen
Hi Thomas, Most fixed in V22, some please see inline comment Thanks. On 2021/9/9 18:33, Thomas Monjalon wrote: > Hi, > > I am having a surface look at the API. > I hope we can do better than previous libs. > > 07/09/2021 14:56, Chengwen Feng: >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -49

Re: [dpdk-dev] [PATCH v21 1/7] dmadev: introduce DMA device library public APIs

2021-09-09 Thread Morten Brørup
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Bruce Richardson > Sent: Thursday, 9 September 2021 16.29 > > On Thu, Sep 09, 2021 at 09:54:27PM +0800, fengchengwen wrote: > > On 2021/9/9 20:45, Bruce Richardson wrote: > > > On Thu, Sep 09, 2021 at 01:29:33PM +0200, Thomas Monjalon wrote: >

Re: [dpdk-dev] [PATCH v21 1/7] dmadev: introduce DMA device library public APIs

2021-09-09 Thread Bruce Richardson
On Thu, Sep 09, 2021 at 04:26:40PM +0200, Thomas Monjalon wrote: > 09/09/2021 15:54, fengchengwen: > > On 2021/9/9 20:45, Bruce Richardson wrote: > > > On Thu, Sep 09, 2021 at 01:29:33PM +0200, Thomas Monjalon wrote: > > >> 09/09/2021 13:18, Bruce Richardson: > > >>> On Thu, Sep 09, 2021 at 12:33:0

Re: [dpdk-dev] [PATCH v21 1/7] dmadev: introduce DMA device library public APIs

2021-09-09 Thread Bruce Richardson
On Thu, Sep 09, 2021 at 09:54:27PM +0800, fengchengwen wrote: > On 2021/9/9 20:45, Bruce Richardson wrote: > > On Thu, Sep 09, 2021 at 01:29:33PM +0200, Thomas Monjalon wrote: > >> 09/09/2021 13:18, Bruce Richardson: > >>> On Thu, Sep 09, 2021 at 12:33:00PM +0200, Thomas Monjalon wrote: > 07/0

Re: [dpdk-dev] [PATCH v21 1/7] dmadev: introduce DMA device library public APIs

2021-09-09 Thread Thomas Monjalon
09/09/2021 15:54, fengchengwen: > On 2021/9/9 20:45, Bruce Richardson wrote: > > On Thu, Sep 09, 2021 at 01:29:33PM +0200, Thomas Monjalon wrote: > >> 09/09/2021 13:18, Bruce Richardson: > >>> On Thu, Sep 09, 2021 at 12:33:00PM +0200, Thomas Monjalon wrote: > 07/09/2021 14:56, Chengwen Feng: >

Re: [dpdk-dev] [PATCH v21 1/7] dmadev: introduce DMA device library public APIs

2021-09-09 Thread Thomas Monjalon
09/09/2021 15:33, fengchengwen: > On 2021/9/9 18:33, Thomas Monjalon wrote: > > 07/09/2021 14:56, Chengwen Feng: > >> + * The DMA controller could have multiple HW-DMA-channels (aka. > >> HW-DMA-queues), > >> + * each HW-DMA-channel should be represented by a dmadev. > >> + * > >> + * The dmadev c

Re: [dpdk-dev] [PATCH v21 1/7] dmadev: introduce DMA device library public APIs

2021-09-09 Thread fengchengwen
On 2021/9/9 20:45, Bruce Richardson wrote: > On Thu, Sep 09, 2021 at 01:29:33PM +0200, Thomas Monjalon wrote: >> 09/09/2021 13:18, Bruce Richardson: >>> On Thu, Sep 09, 2021 at 12:33:00PM +0200, Thomas Monjalon wrote: 07/09/2021 14:56, Chengwen Feng: > + * The first three APIs are used to

Re: [dpdk-dev] [PATCH v21 1/7] dmadev: introduce DMA device library public APIs

2021-09-09 Thread fengchengwen
Thanks for reviewing, mostly OK, a few inlined. On 2021/9/9 18:33, Thomas Monjalon wrote: > Hi, > > I am having a surface look at the API. > I hope we can do better than previous libs. > > 07/09/2021 14:56, Chengwen Feng: >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -496,6 +496,10 @@ F: drive

Re: [dpdk-dev] [PATCH v21 1/7] dmadev: introduce DMA device library public APIs

2021-09-09 Thread Bruce Richardson
On Thu, Sep 09, 2021 at 01:29:33PM +0200, Thomas Monjalon wrote: > 09/09/2021 13:18, Bruce Richardson: > > On Thu, Sep 09, 2021 at 12:33:00PM +0200, Thomas Monjalon wrote: > > > 07/09/2021 14:56, Chengwen Feng: > > > > + * The first three APIs are used to submit the operation request to > > > > th

Re: [dpdk-dev] [PATCH v21 1/7] dmadev: introduce DMA device library public APIs

2021-09-09 Thread Thomas Monjalon
09/09/2021 13:18, Bruce Richardson: > On Thu, Sep 09, 2021 at 12:33:00PM +0200, Thomas Monjalon wrote: > > 07/09/2021 14:56, Chengwen Feng: > > > + * The first three APIs are used to submit the operation request to the > > > virtual > > > + * DMA channel, if the submission is successful, an uint16

Re: [dpdk-dev] [PATCH v21 1/7] dmadev: introduce DMA device library public APIs

2021-09-09 Thread Bruce Richardson
On Thu, Sep 09, 2021 at 12:33:00PM +0200, Thomas Monjalon wrote: > Hi, > > I am having a surface look at the API. > I hope we can do better than previous libs. > A few bits of feedback on your comments and the API below. /Bruce > 07/09/2021 14:56, Chengwen Feng: > > --- a/MAINTAINERS > > +++ b/

Re: [dpdk-dev] [PATCH v21 1/7] dmadev: introduce DMA device library public APIs

2021-09-09 Thread Thomas Monjalon
Hi, I am having a surface look at the API. I hope we can do better than previous libs. 07/09/2021 14:56, Chengwen Feng: > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -496,6 +496,10 @@ F: drivers/raw/skeleton/ > F: app/test/test_rawdev.c > F: doc/guides/prog_guide/rawdev.rst > > +DMA device API

[dpdk-dev] [PATCH v21 1/7] dmadev: introduce DMA device library public APIs

2021-09-07 Thread Chengwen Feng
The 'dmadevice' is a generic type of DMA device. This patch introduce the 'dmadevice' public APIs which expose generic operations that can enable configuration and I/O with the DMA devices. Maintainers update is also included in this patch. Signed-off-by: Chengwen Feng Acked-by: Bruce Richardso