There is no need to do such a check when set macsec for ixgbe, and
reconfig_device_queueand is also useless. If we do not delete this
unnessary code, users have to stop port before enable or disable
macsec, then restart this port after make configuration. All these
process are useless. As this cmdline is a private API which is only
used by ixgbe NIC, so remove it.
Fixes: 597f9fafe13b ("app/testpmd: convert to new Tx offloads API")
Cc: sta...@dpdk.org
Signed-off-by: Wei Zhao <wei.zh...@intel.com>
Tested-by: Peng Yuan <yuan.p...@intel.com>
Acked-by: Bernard Iremonger <bernard.iremon...@intel.com>
---
v2:
-update log info and delete code in disable function
v3:
-update typo in log
---
app/test-pmd/cmdline.c | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index d1e0d44..e7c4bee 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -14044,10 +14044,6 @@ cmd_set_macsec_offload_on_parsed(
if (port_id_is_invalid(port_id, ENABLED_WARN))
return;
- if (!port_is_stopped(port_id)) {
- printf("Please stop port %d first\n", port_id);
- return;
- }
rte_eth_dev_info_get(port_id, &dev_info);
if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_MACSEC_INSERT) {
@@ -14062,7 +14058,6 @@ cmd_set_macsec_offload_on_parsed(
case 0:
ports[port_id].dev_conf.txmode.offloads |=
DEV_TX_OFFLOAD_MACSEC_INSERT;
- cmd_reconfig_device_queue(port_id, 1, 1);
break;
case -ENODEV:
printf("invalid port_id %d\n", port_id);
@@ -14138,10 +14133,6 @@ cmd_set_macsec_offload_off_parsed(
if (port_id_is_invalid(port_id, ENABLED_WARN))
return;
- if (!port_is_stopped(port_id)) {
- printf("Please stop port %d first\n", port_id);
- return;
- }
rte_eth_dev_info_get(port_id, &dev_info);
if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_MACSEC_INSERT) {
@@ -14153,7 +14144,6 @@ cmd_set_macsec_offload_off_parsed(
case 0:
ports[port_id].dev_conf.txmode.offloads &=
~DEV_TX_OFFLOAD_MACSEC_INSERT;
- cmd_reconfig_device_queue(port_id, 1, 1);
break;
case -ENODEV:
printf("invalid port_id %d\n", port_id);
--
2.7.5
